Bug 196041 - WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
Summary: WebKit should throw when trying to create a WKWebView with a related view tha...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-20 15:59 PDT by Chris Dumez
Modified: 2019-03-21 13:31 PDT (History)
4 users (show)

See Also:

Attachments
Patch (3.55 KB, patch)
2019-03-20 16:03 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (5.63 KB, patch)
2019-03-21 13:30 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-03-20 15:59:29 PDT 
WebKit should throw when trying to create a WKWebView with a related view that is using a different data store. We do not support having several WebsiteDataStores sharing the same WebProcess.
Comment 1 Chris Dumez 2019-03-20 15:59:46 PDT 
<rdar://problem/49083230>
Comment 2 Chris Dumez 2019-03-20 16:03:32 PDT 
Created attachment 365424 [details]
Patch
Comment 3 Chris Dumez 2019-03-21 13:11:13 PDT 
Comment on attachment 365424 [details]
Patch

ping review?
Comment 4 Alex Christensen 2019-03-21 13:14:00 PDT 
Comment on attachment 365424 [details]
Patch

We should add a unit test that exercises this code path with try.
Comment 5 Chris Dumez 2019-03-21 13:30:08 PDT 
Created attachment 365606 [details]
Patch
Comment 6 Chris Dumez 2019-03-21 13:31:25 PDT 
Comment on attachment 365606 [details]
Patch

Clearing flags on attachment: 365606

Committed r243320: <https://trac.webkit.org/changeset/243320>
Comment 7 Chris Dumez 2019-03-21 13:31:26 PDT 
All reviewed patches have been landed.  Closing bug.