RESOLVED FIXED 196034
Use WeakPtr instead of storing raw pointers in WebSocket code 
https://bugs.webkit.org/show_bug.cgi?id=196034
Summary Use WeakPtr instead of storing raw pointers in WebSocket code
Alex Christensen
Reported 2019-03-20 14:43:47 PDT
Use WeakPtr instead of storing raw pointers in WebSocket code
Attachments
Patch (10.52 KB, patch)
2019-03-20 14:45 PDT, Alex Christensen 		ggaren: review+
cdumez: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2019-03-20 14:45:20 PDT
Created attachment 365404 [details] Patch
Geoffrey Garen
Comment 2 2019-03-20 16:02:28 PDT
Comment on attachment 365404 [details] Patch r=me
Chris Dumez
Comment 3 2019-03-20 16:08:46 PDT
Comment on attachment 365404 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365404&action=review > Source/WebCore/Modules/websockets/WebSocketHandshake.cpp:126 > + , m_document(document ? makeWeakPtr(*document) : nullptr) eh.. we have a makeWeakPtr() which takes in a raw pointer and does this for you.
Alex Christensen
Comment 4 2019-03-20 16:30:23 PDT
Fixed! https://trac.webkit.org/changeset/243252/webkit
Radar WebKit Bug Importer
Comment 5 2019-03-20 16:31:18 PDT
<rdar://problem/49084881>
Note You need to log in before you can comment on or make changes to this bug.