Bug 196023 - [iOS] Enable fast clicking everywhere
Summary: [iOS] Enable fast clicking everywhere
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-20 12:34 PDT by Dean Jackson
Modified: 2019-03-20 17:10 PDT (History)
3 users (show)

See Also:

Attachments
Patch (8.01 KB, patch)
2019-03-20 12:38 PDT, Dean Jackson 		wenson_hsieh: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2019-03-20 12:34:25 PDT 
[iOS] Enable fast clicking everywhere
Comment 1 Radar WebKit Bug Importer 2019-03-20 12:34:51 PDT 
<rdar://problem/49073589>
Comment 2 Dean Jackson 2019-03-20 12:38:43 PDT 
Created attachment 365384 [details]
Patch
Comment 3 Wenson Hsieh 2019-03-20 14:07:22 PDT 
Comment on attachment 365384 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365384&action=review

> Source/WebKit/Shared/WebPreferences.yaml:1506
> +  defaultValue: true

I think we should still always be able to double tap to zoom on watchOS.

(Let's also confirm that this is what we want on iPhone, not just iPad).
Comment 4 Dean Jackson 2019-03-20 14:10:52 PDT 
Comment on attachment 365384 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365384&action=review

>> Source/WebKit/Shared/WebPreferences.yaml:1506
>> +  defaultValue: true
> 
> I think we should still always be able to double tap to zoom on watchOS.
> 
> (Let's also confirm that this is what we want on iPhone, not just iPad).

We've decided to put it on for now with iPhone. After living on, we might restrict to to just iPad, and then just iPad with sites that haven't set a viewport.
Comment 5 Dean Jackson 2019-03-20 14:28:18 PDT 
Committed r243241: <https://trac.webkit.org/changeset/243241>
Comment 6 Ryan Haddad 2019-03-20 17:10:38 PDT 
This caused http/tests/adClickAttribution/anchor-tag-attributes-validation.html and http/tests/security/anchor-download-block-crossorigin.html to start failing again due to changing console log line numbers. 

Rebaselined in https://trac.webkit.org/changeset/243262/webkit