Bug 196019 - DFGNodeAllocator.h is dead code
Summary: DFGNodeAllocator.h is dead code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Robin Morisset
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-20 11:41 PDT by Robin Morisset
Modified: 2019-03-20 13:38 PDT (History)
8 users (show)

See Also:

Attachments
Patch (3.41 KB, patch)
2019-03-20 11:43 PDT, Robin Morisset 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Morisset 2019-03-20 11:41:01 PDT 
As explained by Yusuke on IRC, the comment on DFG::Node saying that it cannot have a destructor is obsolete since https://trac.webkit.org/changeset/216815/webkit.
This patch removes both the comment and DFGNodeAllocator.h that that patch forgot to remove.
Comment 1 Robin Morisset 2019-03-20 11:43:11 PDT 
Created attachment 365370 [details]
Patch
Comment 2 Yusuke Suzuki 2019-03-20 11:51:17 PDT 
Comment on attachment 365370 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2019-03-20 13:37:07 PDT 
Comment on attachment 365370 [details]
Patch

Clearing flags on attachment: 365370

Committed r243236: <https://trac.webkit.org/changeset/243236>
Comment 4 WebKit Commit Bot 2019-03-20 13:37:08 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-03-20 13:38:22 PDT 
<rdar://problem/49076340>