Bug 196014 - B3::Opcode can fit in a single byte, shrinking B3Value by 8 bytes
Summary: B3::Opcode can fit in a single byte, shrinking B3Value by 8 bytes
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Robin Morisset
Keywords: InRadar
Depends on:
Reported: 2019-03-20 10:41 PDT by Robin Morisset
Modified: 2019-03-21 14:37 PDT (History)
7 users (show)

See Also:

Patch (1.50 KB, patch)
2019-03-20 10:43 PDT, Robin Morisset
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Morisset 2019-03-20 10:41:39 PDT
B3::Opcode has less than one hundred cases, so it can easily fit in one byte (from two currently)
This shrinks B3::Kind from 4 bytes to 2 (by removing the byte of padding at the end).
This in turns eliminate padding from B3Value, shrinking it by 8 bytes (out of 80).
Comment 1 Robin Morisset 2019-03-20 10:43:36 PDT
Created attachment 365356 [details]
Comment 2 Keith Miller 2019-03-20 10:49:17 PDT
Comment on attachment 365356 [details]

Comment 3 WebKit Commit Bot 2019-03-21 14:36:32 PDT
Comment on attachment 365356 [details]

Clearing flags on attachment: 365356

Committed r243330: <https://trac.webkit.org/changeset/243330>
Comment 4 WebKit Commit Bot 2019-03-21 14:36:33 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-03-21 14:37:26 PDT