Bug 196012 - Open source arm64e code.
Summary: Open source arm64e code.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-20 10:15 PDT by Mark Lam
Modified: 2019-03-20 16:33 PDT (History)
13 users (show)

See Also:

Attachments
proposed patch. (86.42 KB, patch)
2019-03-20 11:33 PDT, Mark Lam 		no flags Details | Formatted Diff | Diff
proposed patch. (86.29 KB, patch)
2019-03-20 11:58 PDT, Mark Lam 		keith_miller: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2019-03-20 10:15:40 PDT 
Patch coming.
Comment 1 Radar WebKit Bug Importer 2019-03-20 10:16:03 PDT 
<rdar://problem/49066237>
Comment 2 Mark Lam 2019-03-20 11:33:14 PDT 
Created attachment 365365 [details]
proposed patch.
Comment 3 EWS Watchlist 2019-03-20 11:37:33 PDT 
Attachment 365365 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/PlatformRegisters.cpp:27:  Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/WTF/wtf/PtrTag.cpp:27:  Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 2 in 30 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Mark Lam 2019-03-20 11:58:35 PDT 
Created attachment 365378 [details]
proposed patch.
Comment 5 EWS Watchlist 2019-03-20 12:03:25 PDT 
Attachment 365378 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/PlatformRegisters.cpp:27:  Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/WTF/wtf/PtrTag.cpp:27:  Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 2 in 30 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Keith Miller 2019-03-20 12:03:26 PDT 
Comment on attachment 365378 [details]
proposed patch.

r=me.
Comment 7 Mark Lam 2019-03-20 16:33:39 PDT 
Thanks for the review.  Landed in r243254: <http://trac.webkit.org/r243254>.