Bug 196011 – [iOS WK2] Turn on async overflow scrolling by default

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Simon Fraser (smfr)]

[iOS WK2] Turn on async overflow scrolling by default

[Simon Fraser (smfr)]

Created attachment 365355 [details]
Patch

[EWS Watchlist]

Attachment 365355 [details] did not pass style-queue:


ERROR: LayoutTests/platform/ios-wk2/TestExpectations:1316:  Path does not exist.  [test/expectations] [5]
ERROR: /Volumes/Data/StyleQueue/WebKit/LayoutTests/platform/ios-wk2/TestExpectations:1316:  Path does not exist.  [test/expectations] [5]
Total errors found: 2 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Simon Fraser (smfr)]

Created attachment 365357 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 365357 [details]
Patch

Rejecting attachment 365357 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 365357, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=365357&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=196011&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Processing patch 365357 from bug 196011.
Fetching: https://bugs.webkit.org/attachment.cgi?id=365357
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 22 diffs from patch file(s).
patching file Source/WebKit/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebKit/Shared/WebPreferences.yaml
patching file Source/WebKit/Shared/WebPreferencesDefaultValues.h
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/compositing/layer-creation/absolute-in-async-overflow-scroll-expected.txt
Hunk #1 FAILED at 16.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/compositing/layer-creation/absolute-in-async-overflow-scroll-expected.txt.rej
patching file LayoutTests/platform/ios-wk2/TestExpectations
patching file LayoutTests/platform/ios-wk2/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt
patching file LayoutTests/platform/ios-wk2/compositing/layer-creation/absolute-in-async-overflow-scroll-expected.txt
patching file LayoutTests/platform/ios-wk2/compositing/layer-creation/overflow-scroll-overlap-expected.txt
patching file LayoutTests/platform/ios-wk2/compositing/layer-creation/scroll-partial-update-expected.txt
patching file LayoutTests/platform/ios-wk2/compositing/overflow/content-gains-scrollbars-expected.txt
patching file LayoutTests/platform/ios-wk2/compositing/overflow/overflow-scroll-expected.txt
patching file LayoutTests/platform/ios-wk2/compositing/overflow/overflow-scrollbar-layer-positions-expected.txt
patching file LayoutTests/platform/ios-wk2/compositing/overflow/overflow-scrollbar-layers-expected.txt
patching file LayoutTests/platform/ios-wk2/compositing/overflow/remove-overflow-crash2-expected.txt
patching file LayoutTests/platform/ios-wk2/compositing/overflow/scrollbar-painting-expected.txt
patching file LayoutTests/platform/ios/compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt
patching file LayoutTests/platform/ios/compositing/layers-inside-overflow-scroll-expected.txt
patching file LayoutTests/platform/ios/compositing/overflow/scroll-ancestor-update-expected.txt
patching file LayoutTests/platform/ios/compositing/reflections/nested-reflection-on-overflow-expected.txt
patching file LayoutTests/platform/ios/compositing/self-painting-layers-expected.txt
patching file LayoutTests/scrollingcoordinator/scrolling-tree/positioned-nodes-complex-expected.txt

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: https://webkit-queues.webkit.org/results/11585099

[Simon Fraser (smfr)]

https://trac.webkit.org/r243250

[Jon Lee]

<rdar://problem/48453859> Turn async scrolling for overflow:scroll on by default

[Lucas Forschler]

rdar://problem/48453859

[Shawn Roberts]

Had to roll out in https://trac.webkit.org/changeset/243292/webkit

Was causing 109 layout test failures and 2 crashes.

All 111 failures happen in 243250, all pass in 243249.

Link to results page :

https://build.webkit.org/results/Apple%20iOS%2012%20Simulator%20Debug%20WK2%20(Tests)/r243288%20(2909)/results.html# 

Assertion Crashes : 

ASSERTION FAILED: !m_scrollDimensionsDirty

Will attach test list file on Radar.

[Simon Fraser (smfr)]

Re-landed in https://trac.webkit.org/changeset/243347/webkit.

[Simon Fraser (smfr)]

Test cleanup in https://trac.webkit.org/changeset/243349/webkit

[Simon Fraser (smfr)]

And https://trac.webkit.org/r243350

[Simon Fraser (smfr)]

The asserting tests were:
imported/blink/fast/text/output-isolate-at-end-of-line-crash.html
legacy-animation-engine/imported/blink/fast/text/output-isolate-at-end-of-line-crash.html

These are the same test in 2 places. The test sets overflow: -webkit-paged-y on a MathML element, which is pretty obscure. I filed bug 196123 about it.