Bug 195995 - [ews-build] Improve failure summary string for ApplyPatch step
Summary: [ews-build] Improve failure summary string for ApplyPatch step
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
Keywords: InRadar
Depends on:
Reported: 2019-03-20 04:05 PDT by Aakash Jain
Modified: 2019-03-20 13:08 PDT (History)
8 users (show)

See Also:

Patch (1.34 KB, patch)
2019-03-20 04:08 PDT, Aakash Jain
dewei_zhu: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-03-20 04:05:33 PDT
When ApplyPatch step fails, the buildbot generated summary is: 'Applied patch (failure)'. This isn't good and might be confusing. We should improve this to something like: 'Patch does not apply'.
Comment 1 Aakash Jain 2019-03-20 04:08:34 PDT
Created attachment 365335 [details]
Comment 2 EWS Watchlist 2019-03-20 04:11:26 PDT Comment hidden (obsolete)
Comment 3 Alexey Proskuryakov 2019-03-20 10:26:03 PDT
I'm having second thoughts about making Buildbot changes to tweak status bubble content.

It's useful to have good text messages in Buildbot UI too. However, relying on Buildbot as authoritative source of status bubble UI text will become problematic once the system is in production, as we don't want to restart Buildbot often. So a less intrusive way to polish UI will need to be added.
Comment 4 WebKit Commit Bot 2019-03-20 11:10:37 PDT
Comment on attachment 365335 [details]

Clearing flags on attachment: 365335

Committed r243217: <https://trac.webkit.org/changeset/243217>
Comment 5 WebKit Commit Bot 2019-03-20 11:10:38 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-03-20 11:13:18 PDT