Bug 195993 - ContentChangeObserver build error for not include Element.h
Summary: ContentChangeObserver build error for not include Element.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: cathiechen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-20 01:57 PDT by cathiechen
Modified: 2019-03-21 08:44 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.72 KB, patch)
2019-03-20 02:03 PDT, cathiechen 		no flags Details | Formatted Diff | Diff
Patch (1.71 KB, patch)
2019-03-20 02:06 PDT, cathiechen 		no flags Details | Formatted Diff | Diff
Patch (1.77 KB, patch)
2019-03-20 02:36 PDT, cathiechen 		no flags Details | Formatted Diff | Diff
Patch (1.30 KB, patch)
2019-03-20 02:52 PDT, cathiechen 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description cathiechen 2019-03-20 01:57:47 PDT 
ContentChangeObserver should include Element.h
Comment 1 cathiechen 2019-03-20 02:03:50 PDT 
Created attachment 365327 [details]
Patch
Comment 2 cathiechen 2019-03-20 02:06:10 PDT 
Created attachment 365328 [details]
Patch
Comment 3 Rob Buis 2019-03-20 02:27:02 PDT 
Comment on attachment 365328 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365328&action=review

ContentChangeObserver.h may need more fixes, I see Frame is used as well. Change does not hurt though so let's go for it, with ChangeLog improvement please.

> Source/WebCore/ChangeLog:8
> +        ContentChangeObserver should include Element.h.

Please add some more context, i.e. how you found out there is a build error.
Comment 4 cathiechen 2019-03-20 02:34:40 PDT 
Comment on attachment 365328 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365328&action=review

Hi Rob,

Thanks for the review! :)

>> Source/WebCore/ChangeLog:8
>> +        ContentChangeObserver should include Element.h.
> 
> Please add some more context, i.e. how you found out there is a build error.

Done.
Comment 5 cathiechen 2019-03-20 02:36:05 PDT 
Created attachment 365330 [details]
Patch
Comment 6 Rob Buis 2019-03-20 02:39:38 PDT 
Comment on attachment 365330 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365330&action=review

> Source/WebCore/page/ios/ContentChangeObserver.cpp:33
> +#include "Element.h"

I forgot, this include should not be needed since we include HTMLImageElement.h.
Comment 7 cathiechen 2019-03-20 02:52:36 PDT 
Created attachment 365331 [details]
Patch
Comment 8 Rob Buis 2019-03-21 08:28:45 PDT 
Comment on attachment 365331 [details]
Patch

Retry.
Comment 9 WebKit Commit Bot 2019-03-21 08:43:41 PDT 
Comment on attachment 365331 [details]
Patch

Clearing flags on attachment: 365331

Committed r243290: <https://trac.webkit.org/changeset/243290>
Comment 10 WebKit Commit Bot 2019-03-21 08:43:42 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 11 Radar WebKit Bug Importer 2019-03-21 08:44:19 PDT 
<rdar://problem/49108425>