RESOLVED FIXED195993
ContentChangeObserver build error for not include Element.h 
https://bugs.webkit.org/show_bug.cgi?id=195993
Summary ContentChangeObserver build error for not include Element.h
cathiechen
Reported 2019-03-20 01:57:47 PDT
ContentChangeObserver should include Element.h
Attachments
Patch (1.72 KB, patch)
2019-03-20 02:03 PDT, cathiechen 		no flags
DetailsFormatted DiffDiff
Patch (1.71 KB, patch)
2019-03-20 02:06 PDT, cathiechen 		no flags
DetailsFormatted DiffDiff
Patch (1.77 KB, patch)
2019-03-20 02:36 PDT, cathiechen 		no flags
DetailsFormatted DiffDiff
Patch (1.30 KB, patch)
2019-03-20 02:52 PDT, cathiechen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
cathiechen
Comment 1 2019-03-20 02:03:50 PDT
Created attachment 365327 [details] Patch
cathiechen
Comment 2 2019-03-20 02:06:10 PDT
Created attachment 365328 [details] Patch
Rob Buis
Comment 3 2019-03-20 02:27:02 PDT
Comment on attachment 365328 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365328&action=review ContentChangeObserver.h may need more fixes, I see Frame is used as well. Change does not hurt though so let's go for it, with ChangeLog improvement please. > Source/WebCore/ChangeLog:8 > + ContentChangeObserver should include Element.h. Please add some more context, i.e. how you found out there is a build error.
cathiechen
Comment 4 2019-03-20 02:34:40 PDT
Comment on attachment 365328 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365328&action=review Hi Rob, Thanks for the review! :) >> Source/WebCore/ChangeLog:8 >> + ContentChangeObserver should include Element.h. > > Please add some more context, i.e. how you found out there is a build error. Done.
cathiechen
Comment 5 2019-03-20 02:36:05 PDT
Created attachment 365330 [details] Patch
Rob Buis
Comment 6 2019-03-20 02:39:38 PDT
Comment on attachment 365330 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=365330&action=review > Source/WebCore/page/ios/ContentChangeObserver.cpp:33 > +#include "Element.h" I forgot, this include should not be needed since we include HTMLImageElement.h.
cathiechen
Comment 7 2019-03-20 02:52:36 PDT
Created attachment 365331 [details] Patch
Rob Buis
Comment 8 2019-03-21 08:28:45 PDT
Comment on attachment 365331 [details] Patch Retry.
WebKit Commit Bot
Comment 9 2019-03-21 08:43:41 PDT
Comment on attachment 365331 [details] Patch Clearing flags on attachment: 365331 Committed r243290: <https://trac.webkit.org/changeset/243290>
WebKit Commit Bot
Comment 10 2019-03-21 08:43:42 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 11 2019-03-21 08:44:19 PDT
<rdar://problem/49108425>
Note You need to log in before you can comment on or make changes to this bug.