Bug 195988 - Web Inspector: testCellRoleForRequiredChidren accessibility audit checks for rows in cells
Summary: Web Inspector: testCellRoleForRequiredChidren accessibility audit checks for ...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nobody
Keywords: InRadar
Depends on:
Reported: 2019-03-19 21:58 PDT by Simon Welsh
Modified: 2019-03-24 13:23 PDT (History)
9 users (show)

See Also:

Patch (4.09 KB, patch)
2019-03-22 03:13 PDT, Simon Welsh
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews106 for mac-highsierra-wk2 (2.79 MB, application/zip)
2019-03-22 04:31 PDT, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Welsh 2019-03-19 21:58:48 PDT
The `testCellRoleForRequiredChidren` accessibility audit currently checks to see if all elements with role=cell have a child with role=row. This is clearly the wrong way around.

The fix is to change the relationships object for `testCellRoleForRequiredChidren` in `WebInspectorUI/UserInterface/Controllers/AuditManager.js` to

const relationships = {
    row: ["cell", "gridcell", "columnheader", "rowheader"]

This will also require updating the test further down the same file and should probably include renaming the test to `testRowRoleForRequiredChidren`. There doesn't seem to be test cases that check the behaviour of the audits, so am not sure if one is needed.

I am planning on providing a patch once I have my dev environment set up.
Comment 1 Simon Welsh 2019-03-22 03:13:51 PDT
Created attachment 365699 [details]
Comment 2 EWS Watchlist 2019-03-22 04:31:53 PDT Comment hidden (obsolete)
Comment 3 EWS Watchlist 2019-03-22 04:31:54 PDT Comment hidden (obsolete)
Comment 4 Simon Welsh 2019-03-22 22:35:30 PDT
Test failure doesn't seem related to this change.
Comment 5 WebKit Commit Bot 2019-03-24 13:22:02 PDT
Comment on attachment 365699 [details]

Clearing flags on attachment: 365699

Committed r243425: <https://trac.webkit.org/changeset/243425>
Comment 6 WebKit Commit Bot 2019-03-24 13:22:04 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-03-24 13:23:14 PDT