The `testCellRoleForRequiredChidren` accessibility audit currently checks to see if all elements with role=cell have a child with role=row. This is clearly the wrong way around. The fix is to change the relationships object for `testCellRoleForRequiredChidren` in `WebInspectorUI/UserInterface/Controllers/AuditManager.js` to ``` const relationships = { row: ["cell", "gridcell", "columnheader", "rowheader"] }; ``` This will also require updating the test further down the same file and should probably include renaming the test to `testRowRoleForRequiredChidren`. There doesn't seem to be test cases that check the behaviour of the audits, so am not sure if one is needed. I am planning on providing a patch once I have my dev environment set up.
Created attachment 365699 [details] Patch
Comment on attachment 365699 [details] Patch Attachment 365699 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/11611785 New failing tests: http/wpt/mediarecorder/MediaRecorder-AV-audio-video-dataavailable.html
Created attachment 365709 [details] Archive of layout-test-results from ews106 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Test failure doesn't seem related to this change.
Comment on attachment 365699 [details] Patch Clearing flags on attachment: 365699 Committed r243425: <https://trac.webkit.org/changeset/243425>
All reviewed patches have been landed. Closing bug.
<rdar://problem/49199505>