Bug 195974 – Intl.DateTimeFormat should obey 2-digit hour

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Shane Carr]

The following code has unexpected results.

new Intl.DateTimeFormat('ru', {hour:'2-digit', minute: '2-digit', hour12: false}).format(new Date(2015, 8, 1, 3, 0, 0))
new Intl.DateTimeFormat('ru', {hour:'2-digit', minute: '2-digit', hour12: true}).format(new Date(2015, 8, 1, 3, 0, 0))

The expected output is:

03:00
03:00 AM (or a Cyrillic alternative to "AM")

Safari leaves off the leading 0 digit.

Screenshot:

https://user-images.githubusercontent.com/1235286/54647595-1e093780-4ab4-11e9-971d-a12c32b41e18.png

The bug was reported in ECMA 402:

https://github.com/tc39/ecma402/issues/283

Chrome and Firefox had similar issues which are being tracked.  Chrome has a fix ready to merge.

https://bugs.chromium.org/p/chromium/issues/detail?id=527926
https://bugzilla.mozilla.org/show_bug.cgi?id=1284868

[Radar WebKit Bug Importer]

<rdar://problem/49137227>

[Andy VanWagoner]

Created attachment 365923 [details]
Patch

[EWS Watchlist]

Comment on attachment 365923 [details]
Patch

Attachment 365923 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/11666408

New failing tests:
js/intl-datetimeformat.html

[EWS Watchlist]

Created attachment 365929 [details]
Archive of layout-test-results from ews100 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[Andy VanWagoner]

Created attachment 365935 [details]
Patch

[Keith Miller]

Comment on attachment 365935 [details]
Patch

r=me.

[WebKit Commit Bot]

Comment on attachment 365935 [details]
Patch

Clearing flags on attachment: 365935

Committed r243512: <https://trac.webkit.org/changeset/243512>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.