Bug 195967 – [css-grid] width/height:N% should make the minimum contribution be the minimum size, not the min-content contribution

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Oriol Brufau]

Created attachment 365244 [details]
testcase

What steps will reproduce the problem?
(1) load the attached testcase

What is the expected result?
The grid tracks should be 10px/10px and the grid item should fill that area.

What happens instead?
The grid tracks (and item) are 30px/30px and thus overflow the grid container.

`height` and `width` are set to indefinite percentages, so they behave as auto.
Therefore, the minimum contribution should be the outer size that would result from the minimum size, not the min-content contribution.
This was changed in https://github.com/w3c/csswg-drafts/issues/2367

Chromium has been fixed in https://bugs.chromium.org/p/chromium/issues/detail?id=931474

[Oriol Brufau]

Created attachment 399488 [details]
Patch

[Manuel Rego Casasnovas]

Comment on attachment 399488 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=399488&action=review

Thanks for fixing this, LGTM.

> Source/WebCore/ChangeLog:23
> +        Some cases in the test still fail due to other issues.

Nit: Could you link to bug reports for the "other issues"?

[Oriol Brufau]

(In reply to Manuel Rego Casasnovas from comment #2)
> Comment on attachment 399488 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=399488&action=review
> 
> Thanks for fixing this, LGTM.
> 
> > Source/WebCore/ChangeLog:23
> > +        Some cases in the test still fail due to other issues.
> 
> Nit: Could you link to bug reports for the "other issues"?

OK, actually it seems it's just bug 209461

[Oriol Brufau]

Created attachment 399524 [details]
Patch

[Oriol Brufau]

Created attachment 399525 [details]
Patch

[EWS]

Committed r261767: <https://trac.webkit.org/changeset/261767>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399525 [details].

[Radar WebKit Bug Importer]

<rdar://problem/63293632>