Bug 195963 - [ews-build] Improve summary for CheckOutSource step
Summary: [ews-build] Improve summary for CheckOutSource step
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
Keywords: InRadar
Depends on:
Reported: 2019-03-19 14:43 PDT by Aakash Jain
Modified: 2019-03-19 15:24 PDT (History)
7 users (show)

See Also:

Patch (1.31 KB, patch)
2019-03-19 14:46 PDT, Aakash Jain
lforschler: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2019-03-19 14:43:18 PDT
The summary automatically generated by Buildbot for CheckOutSource step (which uses Buildbot base class git.Git) is 'update'. We should improve this.

Buildbot doesn't seem to respect descriptionDone for git.Git class. Reference: https://github.com/buildbot/buildbot/issues/4666
Comment 1 Aakash Jain 2019-03-19 14:46:46 PDT
Created attachment 365229 [details]
Comment 2 EWS Watchlist 2019-03-19 14:48:02 PDT Comment hidden (obsolete)
Comment 3 Aakash Jain 2019-03-19 14:48:51 PDT
Sample run: https://ews-build.webkit-uat.org/#/builders/19/builds/2215
Comment 4 Lucas Forschler 2019-03-19 15:10:24 PDT
Comment on attachment 365229 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=365229&action=review

> Tools/BuildSlaveSupport/ews-build/steps.py:103
> +

I think you should not abbreviate summary as 'summ'.  
it only saves a couple chars, so just use stepsummary or step_summary.  or, just 'summary'

this could also be written:
if self.results != SUCCESS:
    return {u'step': u'Failed to updated working directory'}
     return {u'step': u'Cleaned and updated working directory' }

which avoids the variable name altogether.
Comment 5 Aakash Jain 2019-03-19 15:22:54 PDT
Committed r243174: <https://trac.webkit.org/changeset/243174>
Comment 6 Aakash Jain 2019-03-19 15:24:34 PDT
> this could also be written:
Thanks. used this.
Comment 7 Radar WebKit Bug Importer 2019-03-19 15:24:53 PDT