Bug 195960 - Remove the SVG property tear off objects of SVGAnimatedPreserveAspectRatio
Summary: Remove the SVG property tear off objects of SVGAnimatedPreserveAspectRatio
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on: 195949
Blocks: 191237 196025
  Show dependency treegraph
 
Reported: 2019-03-19 12:32 PDT by Said Abou-Hallawa
Modified: 2019-03-20 15:58 PDT (History)
4 users (show)

See Also:


Attachments
Patch (112.44 KB, patch)
2019-03-19 12:35 PDT, Said Abou-Hallawa
no flags Details | Formatted Diff | Diff
Patch for review (70.21 KB, patch)
2019-03-19 12:38 PDT, Said Abou-Hallawa
no flags Details | Formatted Diff | Diff
Patch (70.12 KB, patch)
2019-03-19 18:22 PDT, Said Abou-Hallawa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2019-03-19 12:32:02 PDT
This is very similar to https://bugs.webkit.org/show_bug.cgi?id=195949. The changes should be almost the same expect the animation function for SVGRect is additive while it is discrete for SVGPreserveAspectRatio.
Comment 1 Said Abou-Hallawa 2019-03-19 12:35:12 PDT
Created attachment 365205 [details]
Patch
Comment 2 Said Abou-Hallawa 2019-03-19 12:38:40 PDT
Created attachment 365208 [details]
Patch for review
Comment 3 Simon Fraser (smfr) 2019-03-19 15:58:44 PDT
Comment on attachment 365208 [details]
Patch for review

View in context: https://bugs.webkit.org/attachment.cgi?id=365208&action=review

> Source/WebCore/ChangeLog:12
> +        -- Define SVGAnimatedPreserveAspectRatio to be SVGAnimatedValueProperty<
> +           SVGPreserveAspectRatio>.
> +
> +        -- Make SVGPreserveAspectRatio be derived form SVGValueProperty<S
> +           VGPreserveAspectRatioValue>.

Bad wrapping.

> Source/WebCore/svg/properties/SVGAnimatedPropertyAnimatorImpl.h:84
> +        return std::unique_ptr<SVGAnimatedPreserveAspectRatioAnimator>(new SVGAnimatedPreserveAspectRatioAnimator(attributeName, animated, animationMode, calcMode, isAccumulated, isAdditive));

make_unique<>
Comment 4 Said Abou-Hallawa 2019-03-19 18:22:45 PDT
Created attachment 365279 [details]
Patch
Comment 5 WebKit Commit Bot 2019-03-19 18:49:36 PDT
Comment on attachment 365279 [details]
Patch

Clearing flags on attachment: 365279

Committed r243185: <https://trac.webkit.org/changeset/243185>
Comment 6 WebKit Commit Bot 2019-03-19 18:49:38 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-03-19 18:50:22 PDT
<rdar://problem/49045550>