Bug 195957 - Adopt RegistrableDomain in the Storage Access API prompt code paths
Summary: Adopt RegistrableDomain in the Storage Access API prompt code paths
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on: 195866
Blocks:
  Show dependency tree / graph
 
Reported: 2019-03-19 11:22 PDT by Brent Fulgham
Modified: 2019-03-20 09:41 PDT (History)
5 users (show)

See Also:

Attachments
Patch (16.42 KB, patch)
2019-03-19 20:35 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch (16.54 KB, patch)
2019-03-20 08:57 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2019-03-19 11:22:17 PDT 
While making the code changes in Bug 195866 we noticed that strings were being used to pass the origins for the API calls. We should adopt the RegistrableDomain class to improve type safety and avoid introducing bugs in the future.
Comment 1 Radar WebKit Bug Importer 2019-03-19 20:30:12 PDT 
<rdar://problem/49048028>
Comment 2 Brent Fulgham 2019-03-19 20:35:30 PDT 
Created attachment 365298 [details]
Patch
Comment 3 Brent Fulgham 2019-03-20 08:57:47 PDT 
Created attachment 365348 [details]
Patch
Comment 4 Brent Fulgham 2019-03-20 09:17:19 PDT 
Comment on attachment 365348 [details]
Patch

Thanks for reviewing!
Comment 5 WebKit Commit Bot 2019-03-20 09:41:21 PDT 
Comment on attachment 365348 [details]
Patch

Clearing flags on attachment: 365348

Committed r243210: <https://trac.webkit.org/changeset/243210>
Comment 6 WebKit Commit Bot 2019-03-20 09:41:23 PDT 
All reviewed patches have been landed.  Closing bug.