WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
195956
[CMake] Support more clang and gcc sanitizers
https://bugs.webkit.org/show_bug.cgi?id=195956
Summary
[CMake] Support more clang and gcc sanitizers
Christopher Reid
Reported
2019-03-19 11:21:29 PDT
WebKitCompilerFlags.cmake currently only supports asan. We should support compiling with other sanitizers like ubsan, thread, memory, and leak.
Attachments
Patch
(4.98 KB, patch)
2019-03-19 13:48 PDT
,
Christopher Reid
no flags
Details
Formatted Diff
Diff
Patch
(5.00 KB, patch)
2019-03-19 14:00 PDT
,
Christopher Reid
no flags
Details
Formatted Diff
Diff
Patch for landing
(6.59 KB, patch)
2019-03-19 15:31 PDT
,
Christopher Reid
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Christopher Reid
Comment 1
2019-03-19 13:48:06 PDT
Created
attachment 365222
[details]
Patch
Christopher Reid
Comment 2
2019-03-19 14:00:32 PDT
Created
attachment 365227
[details]
Patch
Michael Catanzaro
Comment 3
2019-03-19 14:09:25 PDT
Comment on
attachment 365227
[details]
Patch Please check Tools/Scripts and fix up any existing uses of ENABLE_ADDRESS_SANITIZER there. We have e.g. set-webkit-configuration --asan that will be broken by this change.
Christopher Reid
Comment 4
2019-03-19 15:31:19 PDT
Created
attachment 365243
[details]
Patch for landing
WebKit Commit Bot
Comment 5
2019-03-19 16:34:09 PDT
Comment on
attachment 365243
[details]
Patch for landing Clearing flags on attachment: 365243 Committed
r243179
: <
https://trac.webkit.org/changeset/243179
>
WebKit Commit Bot
Comment 6
2019-03-19 16:34:10 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug