Bug 195956 - [CMake] Support more clang and gcc sanitizers
Summary: [CMake] Support more clang and gcc sanitizers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CMake (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-03-19 11:21 PDT by Christopher Reid
Modified: 2019-03-19 16:34 PDT (History)
8 users (show)

See Also:

Attachments
Patch (4.98 KB, patch)
2019-03-19 13:48 PDT, Christopher Reid 		no flags Details | Formatted Diff | Diff
Patch (5.00 KB, patch)
2019-03-19 14:00 PDT, Christopher Reid 		no flags Details | Formatted Diff | Diff
Patch for landing (6.59 KB, patch)
2019-03-19 15:31 PDT, Christopher Reid 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Christopher Reid 2019-03-19 11:21:29 PDT 
WebKitCompilerFlags.cmake currently only supports asan. We should support compiling with other sanitizers like ubsan, thread, memory, and leak.
Comment 1 Christopher Reid 2019-03-19 13:48:06 PDT 
Created attachment 365222 [details]
Patch
Comment 2 Christopher Reid 2019-03-19 14:00:32 PDT 
Created attachment 365227 [details]
Patch
Comment 3 Michael Catanzaro 2019-03-19 14:09:25 PDT 
Comment on attachment 365227 [details]
Patch

Please check Tools/Scripts and fix up any existing uses of ENABLE_ADDRESS_SANITIZER there. We have e.g. set-webkit-configuration --asan that will be broken by this change.
Comment 4 Christopher Reid 2019-03-19 15:31:19 PDT 
Created attachment 365243 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2019-03-19 16:34:09 PDT 
Comment on attachment 365243 [details]
Patch for landing

Clearing flags on attachment: 365243

Committed r243179: <https://trac.webkit.org/changeset/243179>
Comment 6 WebKit Commit Bot 2019-03-19 16:34:10 PDT 
All reviewed patches have been landed.  Closing bug.