Bug 195955 – REGRESSION (r242369): Only use picker-supported UTIs when creating image picker

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Conrad Shultz]

r242369 started passing UTIs to -[UIImagePickerController setMediaTypes:] that correspond to types accepted by the file input element. However, UIImagePickerController expects a specific subset of UTIs. In the worst case, if no expected types are passed, this can cause a crash.

[Conrad Shultz]

<rdar://problem/48788916>

[Conrad Shultz]

Created attachment 365189 [details]
Patch

[EWS Watchlist]

Comment on attachment 365189 [details]
Patch

Attachment 365189 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/11568797

New failing tests:
imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-constructor.html

[EWS Watchlist]

Created attachment 365206 [details]
Archive of layout-test-results from ews104 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6

[Conrad Shultz]

Crash appears unrelated; apparently we aren’t able to dynamically load a constant:

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   com.apple.WebCore             	0x00000007080022f3 WTFCrashWithInfo(int, char const*, char const*, int) + 19 (Assertions.h:566)
1   com.apple.WebCore             	0x00000007083e11a0 initAVEncoderBitRateKey() + 128 (MediaRecorderPrivateWriterCocoa.mm:55)

which is:

void* constant = dlsym(framework##Library(), #name); \
RELEASE_ASSERT_WITH_MESSAGE(constant, "%s", dlerror()); \

[Wenson Hsieh]

Comment on attachment 365189 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365189&action=review

> Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm:339
> +                    if (UTTypeConformsTo((CFStringRef)acceptedMediaType, (CFStringRef)availableMediaType)) {

Nit - __bridge

[Chris Dumez]

Comment on attachment 365189 [details]
Patch

r=me

[Conrad Shultz]

(In reply to Wenson Hsieh from comment #6)
> Comment on attachment 365189 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=365189&action=review
> 
> > Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm:339
> > +                    if (UTTypeConformsTo((CFStringRef)acceptedMediaType, (CFStringRef)availableMediaType)) {
> 
> Nit - __bridge

Fixed. Thanks!

[Conrad Shultz]

Committed r243168
	M	Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm
	M	Source/WebKit/ChangeLog
r243168 = d69c31b5ad59c2a303902c9e018ec617335702ed (refs/remotes/origin/master)