Bug 195936 - Simplify Cocoa platform user agent logic by using string constants instead of function calls for the frozen parts
Summary: Simplify Cocoa platform user agent logic by using string constants instead of...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Maciej Stachowiak
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-18 23:06 PDT by Maciej Stachowiak
Modified: 2019-03-19 19:56 PDT (History)
4 users (show)

See Also:


Attachments
Patch (6.79 KB, patch)
2019-03-19 00:45 PDT, Maciej Stachowiak
dino: review+
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews113 for mac-highsierra (2.34 MB, application/zip)
2019-03-19 02:30 PDT, EWS Watchlist
no flags Details
Archive of layout-test-results from ews104 for mac-highsierra-wk2 (2.83 MB, application/zip)
2019-03-19 03:03 PDT, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Stachowiak 2019-03-18 23:06:58 PDT
Simplify Cocoa platform user agent logic by using string constants instead of function calls for the frozen parts
Comment 1 Maciej Stachowiak 2019-03-19 00:45:40 PDT
Created attachment 365134 [details]
Patch
Comment 2 EWS Watchlist 2019-03-19 02:30:44 PDT
Comment on attachment 365134 [details]
Patch

Attachment 365134 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/11560333

New failing tests:
http/tests/security/cross-origin-worker-indexeddb.html
http/tests/security/cross-origin-indexeddb.html
Comment 3 EWS Watchlist 2019-03-19 02:30:46 PDT
Created attachment 365141 [details]
Archive of layout-test-results from ews113 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-highsierra  Platform: Mac OS X 10.13.6
Comment 4 EWS Watchlist 2019-03-19 03:03:40 PDT
Comment on attachment 365134 [details]
Patch

Attachment 365134 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/11561087

New failing tests:
imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-constructor.html
Comment 5 EWS Watchlist 2019-03-19 03:03:41 PDT
Created attachment 365143 [details]
Archive of layout-test-results from ews104 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6
Comment 6 Maciej Stachowiak 2019-03-19 09:54:25 PDT
It's hard to see how these changes could cause these particular test failures. And it looks like other unrelated patches have been experiencing the same failures, including these which do not even materially affect the Mac port:

https://bugs.webkit.org/attachment.cgi?id=365157&action=prettypatch
https://bugs.webkit.org/attachment.cgi?id=365154&action=prettypatch
https://bugs.webkit.org/attachment.cgi?id=365152&action=prettypatch

So I think the failures are a problem with EWS, or latent flaky crashes.
Comment 7 Maciej Stachowiak 2019-03-19 19:52:35 PDT
Committed r243187: <https://trac.webkit.org/changeset/243187>
Comment 8 Radar WebKit Bug Importer 2019-03-19 19:56:38 PDT
<rdar://problem/49047274>