WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
195904
Make WTFLogChannelState and WTFLogLevel enum classes
https://bugs.webkit.org/show_bug.cgi?id=195904
Summary
Make WTFLogChannelState and WTFLogLevel enum classes
Alex Christensen
Reported
2019-03-18 13:06:15 PDT
Make WTFLogChannelState and WTFLogLevel enum classes
Attachments
Patch
(57.36 KB, patch)
2019-03-18 13:09 PDT
,
Alex Christensen
no flags
Details
Formatted Diff
Diff
Patch
(44.54 KB, patch)
2019-03-18 14:38 PDT
,
Alex Christensen
no flags
Details
Formatted Diff
Diff
Patch
(46.30 KB, patch)
2019-03-18 15:24 PDT
,
Alex Christensen
no flags
Details
Formatted Diff
Diff
Patch
(46.26 KB, patch)
2019-03-19 09:06 PDT
,
Alex Christensen
no flags
Details
Formatted Diff
Diff
Show Obsolete
(3)
View All
Add attachment
proposed patch, testcase, etc.
Alex Christensen
Comment 1
2019-03-18 13:09:32 PDT
Created
attachment 365047
[details]
Patch
Eric Carlson
Comment 2
2019-03-18 13:31:06 PDT
Comment on
attachment 365047
[details]
Patch Thanks Alex!
Alex Christensen
Comment 3
2019-03-18 14:38:00 PDT
Created
attachment 365067
[details]
Patch
EWS Watchlist
Comment 4
2019-03-18 14:40:28 PDT
Attachment 365067
[details]
did not pass style-queue: ERROR: Source/WTF/wtf/Assertions.h:182: LOG_CHANNEL is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Assertions.h:185: LOG_CHANNEL is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 2 in 25 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alex Christensen
Comment 5
2019-03-18 15:24:27 PDT
Created
attachment 365075
[details]
Patch
EWS Watchlist
Comment 6
2019-03-18 15:29:15 PDT
Attachment 365075
[details]
did not pass style-queue: ERROR: Source/WTF/wtf/Assertions.h:182: LOG_CHANNEL is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Assertions.h:185: LOG_CHANNEL is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 2 in 27 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 7
2019-03-18 23:36:17 PDT
Comment on
attachment 365075
[details]
Patch Clearing flags on attachment: 365075 Committed
r243132
: <
https://trac.webkit.org/changeset/243132
>
WebKit Commit Bot
Comment 8
2019-03-18 23:36:19 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9
2019-03-18 23:37:42 PDT
<
rdar://problem/49008895
>
Michael Catanzaro
Comment 10
2019-03-19 06:21:14 PDT
GTK is broken: In file included from /usr/include/X11/Xlib.h:44, from ../../Source/WebCore/plugins/npapi.h:89, from ../../Tools/DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h:1, from ../../Tools/DumpRenderTree/TestNetscapePlugIn/TestObject.h:26, from ../../Tools/DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:26: ../../Source/WTF/wtf/Assertions.h:153:36: error: expected identifier before numeric constant 153 | enum class WTFLogLevel : uint8_t { Always, Error, Warning, Info, Debug }; | ^~~~~~ We won't ever be able to use the name "Always" because it makes Assertions.h conflict with Xlib.h, and it's not practical to ensure these headers are never included together. Xlib.h is the absolute worst (it defines a bunch of very common names without any namespace) but we're stuck with it.
Michael Catanzaro
Comment 11
2019-03-19 06:24:57 PDT
I think the options are: (a) Rename WTFLogLevel::Always to something less-appropriate (b) Remain an old-style enum forever Let's go with (b) for now, just to get the build working until we have time to bikeshed about naming.
Michael Catanzaro
Comment 12
2019-03-19 06:25:21 PDT
Reverted
r243132
for reason: Broke GTK build Committed
r243135
: <
https://trac.webkit.org/changeset/243135
>
Alex Christensen
Comment 13
2019-03-19 07:03:29 PDT
WTFLogLevel::Always_ could work
Michael Catanzaro
Comment 14
2019-03-19 07:59:10 PDT
(In reply to Michael Catanzaro from
comment #11
)
> I think the options are: > > (a) Rename WTFLogLevel::Always to something less-appropriate > (b) Remain an old-style enum forever > > Let's go with (b) for now, just to get the build working until we have time > to bikeshed about naming.
Phil suggested #undef Always, so that's another option. It will fail if Assertion.h gets included before anything that actually needs to use Xlib.h's Always. I think nothing in WebKit will ever want to do that, but other external headers might... using #undef in headers is not exactly safe. Then again, nothing about unified builds is safe.
Alex Christensen
Comment 15
2019-03-19 09:06:57 PDT
Created
attachment 365168
[details]
Patch
EWS Watchlist
Comment 16
2019-03-19 09:09:25 PDT
Attachment 365168
[details]
did not pass style-queue: ERROR: Source/WTF/wtf/Assertions.h:183: LOG_CHANNEL is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] ERROR: Source/WTF/wtf/Assertions.h:186: LOG_CHANNEL is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 2 in 27 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 17
2019-03-19 09:47:10 PDT
Comment on
attachment 365168
[details]
Patch Clearing flags on attachment: 365168 Committed
r243141
: <
https://trac.webkit.org/changeset/243141
>
WebKit Commit Bot
Comment 18
2019-03-19 09:47:11 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug