Bug 195900 - [GStreamer][EME][Clearkey] Take a lock in keys() method
Summary: [GStreamer][EME][Clearkey] Take a lock in keys() method
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Charlie Turner
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-03-18 11:29 PDT by Charlie Turner
Modified: 2019-03-21 05:14 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.62 KB, patch)
2019-03-18 11:33 PDT, Charlie Turner 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (2.66 MB, application/zip)
2019-03-18 14:48 PDT, EWS Watchlist 		no flags Details
Patch for landing (2.62 KB, patch)
2019-03-21 04:33 PDT, Charlie Turner 		no flags Details | Formatted Diff | Diff
Patch for landing (2.63 KB, patch)
2019-03-21 04:35 PDT, Charlie Turner 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Charlie Turner 2019-03-18 11:29:58 PDT 
[GStreamer][EME][Clearkey] Take a lock in keys() method
Comment 1 Charlie Turner 2019-03-18 11:33:11 PDT 
Created attachment 365039 [details]
Patch
Comment 2 EWS Watchlist 2019-03-18 14:48:36 PDT 
Comment on attachment 365039 [details]
Patch

Attachment 365039 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/11553813

New failing tests:
storage/indexeddb/modern/idbtransaction-objectstore-failures-private.html
Comment 3 EWS Watchlist 2019-03-18 14:48:38 PDT 
Created attachment 365068 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6
Comment 4 Charlie Turner 2019-03-21 04:33:09 PDT 
Created attachment 365533 [details]
Patch for landing
Comment 5 Charlie Turner 2019-03-21 04:35:04 PDT 
Created attachment 365534 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2019-03-21 05:14:09 PDT 
Comment on attachment 365534 [details]
Patch for landing

Clearing flags on attachment: 365534

Committed r243287: <https://trac.webkit.org/changeset/243287>
Comment 7 WebKit Commit Bot 2019-03-21 05:14:11 PDT 
All reviewed patches have been landed.  Closing bug.