Bug 19589 - Patch to re-enable some layout tests
Summary: Patch to re-enable some layout tests
Status: UNCONFIRMED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P3 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 19569
  Show dependency treegraph
 
Reported: 2008-06-16 11:31 PDT by Jean-Charles Verdié
Modified: 2010-06-10 15:43 PDT (History)
1 user (show)

See Also:


Attachments
re-enable layout tests which do not crash or hang (45.62 KB, patch)
2008-06-16 11:38 PDT, Jean-Charles Verdié
ggaren: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jean-Charles Verdié 2008-06-16 11:31:28 PDT
according to https://bugs.webkit.org/show_bug.cgi?id=19569
there are 51 layout disabled
47 of them are not crashing anymore and should be re-enabled.

The patch is pretty huge but I'm not sure how to split it correctly without it being a hassle :(
Comment 1 Jean-Charles Verdié 2008-06-16 11:38:52 PDT
Created attachment 21738 [details]
re-enable layout tests which do not crash or hang
Comment 2 Robert Blaut 2008-06-16 11:53:38 PDT
(In reply to comment #0)
> according to https://bugs.webkit.org/show_bug.cgi?id=19569
> there are 51 layout disabled
> 47 of them are not crashing anymore and should be re-enabled.

Thank you for your contribution. Jean-Charles, you should consider that many of disabled tests were disabled because of other problems than crash. For example:bug 11662, http://trac.webkit.org/changeset/28763

I think the best way for finding a real purpose of disabling test is checking revision logs of these tests: http://trac.webkit.org/browser
Comment 3 Maciej Stachowiak 2008-06-20 11:24:54 PDT
What Robert suggests (reviewing the revision history of each test, or the ChangeLog) is a good idea. I forgot that some tests were off because they fail depending on system configuration. For those, we'd like to change them so they don't depend on the particular fonts the user has installed, and we could use a bug to represent that.
Comment 4 Geoffrey Garen 2008-06-23 12:34:49 PDT
Comment on attachment 21738 [details]
re-enable layout tests which do not crash or hang

I guess I'll r- this patch, since it sounds like not all of these tests should be re-enabled right away.