Bug 195888 - REGRESSION(r243058): [GStreamer] 3 tests now timing out
Summary: REGRESSION(r243058): [GStreamer] 3 tests now timing out
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-18 08:45 PDT by Philippe Normand
Modified: 2019-03-19 07:54 PDT (History)
2 users (show)

See Also:

Attachments
Patch (5.59 KB, patch)
2019-03-18 08:52 PDT, Philippe Normand 		calvaris: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2019-03-18 08:45:11 PDT 
.
Comment 1 Philippe Normand 2019-03-18 08:46:43 PDT 
Regressions: Unexpected timeouts (3)
  http/tests/media/video-play-stall-seek.html [ Timeout ]
  http/wpt/fetch/dnt-header-after-redirection.html [ Timeout ]
  imported/w3c/web-platform-tests/resource-timing/resource_initiator_types.html [ Timeout ]
Comment 2 Philippe Normand 2019-03-18 08:52:44 PDT 
Created attachment 365016 [details]
Patch
Comment 3 Xabier Rodríguez Calvar 2019-03-19 07:17:08 PDT 
Comment on attachment 365016 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365016&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:291
> +    mutable uint64_t m_networkReadPosition { 0 };

Do you need this variable to be mutable as well?
Comment 4 Philippe Normand 2019-03-19 07:49:52 PDT 
Comment on attachment 365016 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=365016&action=review

>> Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:291
>> +    mutable uint64_t m_networkReadPosition { 0 };
> 
> Do you need this variable to be mutable as well?

It is not. Good catch!
Comment 5 Philippe Normand 2019-03-19 07:53:26 PDT 
Committed r243140: <https://trac.webkit.org/changeset/243140>
Comment 6 Radar WebKit Bug Importer 2019-03-19 07:54:16 PDT 
<rdar://problem/49018785>