Bug 195883 – [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Adrian Perez]

It's basically impossible to know at a glance what the actual
problem is with the current error output:

[5/8] Generating ../docs-build.stamp
FAILED: docs-build.stamp
cd /home/aperez/wpe/WebKit/build-rc && /usr/bin/cmake -E env CC=/usr/lib/ccache/bin/cc "CFLAGS=-fdiagnostics-color=always -Wextra -Wall -Wno-expansion-to-defined -Wno-psabi -Wno-maybe-uninitialized -Wwrite-strings -Wundef -Wpointer-arith -Wmissing-format-attribute -Wformat-
security -Wcast-align  -fno-strict-aliasing -fno-exceptions -Wno-unused-parameter" /home/aperez/wpe/WebKit/Tools/gtkdoc/generate-gtkdoc --wpe && touch docs-build.stamp
Traceback (most recent call last):
  File "/home/aperez/wpe/WebKit/Tools/gtkdoc/generate-gtkdoc", line 260, in <module>
    build_gtkdoc_for_wpe(arguments)
  File "/home/aperez/wpe/WebKit/Tools/gtkdoc/generate-gtkdoc", line 196, in build_gtkdoc_for_wpe
    webextensions_generator = get_generator_for_config(common.build_path('gtkdoc-webextensions.cfg'), arguments.virtual_root)
  File "/home/aperez/wpe/WebKit/Tools/gtkdoc/generate-gtkdoc", line 141, in get_generator_for_config
    'ignored_files': files_to_ignore(source_dirs, headers),
  File "/home/aperez/wpe/WebKit/Tools/gtkdoc/gtkdoc.py", line 455, in __init__
    '--cflags'], print_output=False)
  File "/home/aperez/wpe/WebKit/Tools/gtkdoc/gtkdoc.py", line 222, in _run_command
    % (args[0], process.returncode))
Exception: pkg-config produced a non-zero return code 1
[6/8] Generating ../../DerivedSources/WebInspectorUI/InspectorGResourceBundle.c
ninja: build stopped: subcommand failed.

[Adrian Perez]

Created attachment 365011 [details]
Patch


With this patch; when the same error situation as above is reached,
the following is logged:

Exception: pkg-config produced a non-zero return code 1                                                        
Command:                                                                                                                           
  pkg-config /home/aperez/wpe/WebKit/build-rc/wpe-web-extension-0.1.pc --cflags                                                                            
Error output:                                                      
  Package wpe-0.2 was not found in the pkg-config search path.
  Perhaps you should add the directory containing 'wpe-0.2.pc'
  to the PKG_CONFIG_PATH environment variable                     
  Package 'wpe-0.2', required by 'wpe-web-extension-0.1', not found

[Adrian Perez]

FWIW, the failure from the WPE EWS seems unrelated — it needed
cleaning of the build directory because the CMake cache was botched
after r243060.

[WebKit Commit Bot]

Comment on attachment 365011 [details]
Patch

Clearing flags on attachment: 365011

Committed r243062: <https://trac.webkit.org/changeset/243062>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/48979337>