RESOLVED WORKSFORME 195882
[ews-build] API and layout test builders shouldn't apply Patch 
https://bugs.webkit.org/show_bug.cgi?id=195882
Summary [ews-build] API and layout test builders shouldn't apply Patch
Aakash Jain
Reported 2019-03-18 05:34:14 PDT
Since API and layout test builders download archive and run test for that archive, they don't need to apply the patch to working directory. Similarly they don't even need to update the working directory. These steps might take long time for large patches (and might even fail in case of network issues). We shouldn't run these steps on these builders.
Attachments
Patch (1.70 KB, patch)
2019-03-18 05:35 PDT, Aakash Jain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Aakash Jain
Comment 1 2019-03-18 05:35:54 PDT
Created attachment 365010 [details] Patch
EWS Watchlist
Comment 2 2019-03-18 05:37:32 PDT Comment hidden (obsolete)
Jonathan Bedard
Comment 3 2019-03-18 09:06:57 PDT
The checkout is relevant for both API and layout tests, though. As is the patch. For layout tests, if we don't apply the patch, we won't get any updates to the layout tests or test results. For API tests, it's less of a concern since the only thing we'd potentially be missing is harness code in webkitpy. In both cases, I feel like not applying the patch is confusing and undermines the purpose of EWS. We want EWS to fail if someone uploads a tools patch that breaks layout tests, right?
Note You need to log in before you can comment on or make changes to this bug.