195882 – [ews-build] API and layout test builders shouldn't apply Patch

Bug 195882 - [ews-build] API and layout test builders shouldn't apply Patch

Summary: [ews-build] API and layout test builders shouldn't apply Patch

Status:	RESOLVED WORKSFORME

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	Tools / Tests (show other bugs)
Version:	Other
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Aakash Jain

URL:
Keywords:

Depends on:
Blocks:

Reported:	2019-03-18 05:34 PDT by Aakash Jain
Modified:	2019-07-10 09:31 PDT (History)
CC List:	5 users (show)

See Also:

Attachments
Patch (1.70 KB, patch) 2019-03-18 05:35 PDT, Aakash Jain	no flags	Details \| Formatted Diff \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Aakash Jain 2019-03-18 05:34:14 PDT

Since API and layout test builders download archive and run test for that archive, they don't need to apply the patch to working directory. Similarly they don't even need to update the working directory. These steps might take long time for large patches (and might even fail in case of network issues). We shouldn't run these steps on these builders.

Comment 1 Aakash Jain 2019-03-18 05:35:54 PDT

Created attachment 365010 [details]
Patch

Comment 2 EWS Watchlist 2019-03-18 05:37:32 PDT Comment hidden (obsolete)

Attachment 365010 [details] did not pass style-queue:


ERROR: Tools/BuildSlaveSupport/ews-build/factories.py:102:  [TestFactory.__init__] Undefined variable 'ConfigureBuild'  [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/factories.py:103:  [TestFactory.__init__] Undefined variable 'ValidatePatch'  [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/factories.py:104:  [TestFactory.__init__] Undefined variable 'PrintConfiguration'  [pylint/E0602] [5]
ERROR: Tools/BuildSlaveSupport/ews-build/factories.py:105:  [TestFactory.__init__] Undefined variable 'CheckOutSource'  [pylint/E0602] [5]
Total errors found: 4 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Jonathan Bedard 2019-03-18 09:06:57 PDT

The checkout is relevant for both API and layout tests, though. As is the patch. For layout tests, if we don't apply the patch, we won't get any updates to the layout tests or test results. For API tests, it's less of a concern since the only thing we'd potentially be missing is harness code in webkitpy.

In both cases, I feel like not applying the patch is confusing and undermines the purpose of EWS. We want EWS to fail if someone uploads a tools patch that breaks layout tests, right?