RESOLVED FIXED 195871
Structure::flattenDictionary() should clear unused property slots. 
https://bugs.webkit.org/show_bug.cgi?id=195871
Summary Structure::flattenDictionary() should clear unused property slots.
Mark Lam
Reported 2019-03-17 20:00:11 PDT
It current attempts to do this but fails because it's actually clearing up the preCapacity region instead. <rdar://problem/48959497>
Attachments
proposed patch. (3.42 KB, patch)
2019-03-17 20:04 PDT, Mark Lam 		msaboff: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2019-03-17 20:04:29 PDT
Created attachment 364996 [details] proposed patch.
Michael Saboff
Comment 2 2019-03-18 07:38:46 PDT
Comment on attachment 364996 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=364996&action=review r=me after addressing ChangeLog wording. > Source/JavaScriptCore/ChangeLog:9 > + It current attempts to do this but fails because it's actually clearing up the Should this read *currently* ? > Source/JavaScriptCore/ChangeLog:10 > + preCapacity region instead. The fix i simply to account for the preCapacity Should this read "The fix is simply to ..."?
Mark Lam
Comment 3 2019-03-18 09:18:50 PDT
Thanks for the review. I've fixed the typos. Landed in r243069: <http://trac.webkit.org/r243069>.
Note You need to log in before you can comment on or make changes to this bug.