Bug 195871 - Structure::flattenDictionary() should clear unused property slots.
Summary: Structure::flattenDictionary() should clear unused property slots.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-17 20:00 PDT by Mark Lam
Modified: 2019-03-18 09:18 PDT (History)
9 users (show)

See Also:


Attachments
proposed patch. (3.42 KB, patch)
2019-03-17 20:04 PDT, Mark Lam
msaboff: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2019-03-17 20:00:11 PDT
It current attempts to do this but fails because it's actually clearing up the preCapacity region instead.

<rdar://problem/48959497>
Comment 1 Mark Lam 2019-03-17 20:04:29 PDT
Created attachment 364996 [details]
proposed patch.
Comment 2 Michael Saboff 2019-03-18 07:38:46 PDT
Comment on attachment 364996 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=364996&action=review

r=me after addressing ChangeLog wording.

> Source/JavaScriptCore/ChangeLog:9
> +        It current attempts to do this but fails because it's actually clearing up the

Should this read *currently* ?

> Source/JavaScriptCore/ChangeLog:10
> +        preCapacity region instead.  The fix i simply to account for the preCapacity

Should this read "The fix is simply to ..."?
Comment 3 Mark Lam 2019-03-18 09:18:50 PDT
Thanks for the review.  I've fixed the typos.  Landed in r243069: <http://trac.webkit.org/r243069>.