Bug 195860 - Fix WPE and GTK Debug builds after r243049
Summary: Fix WPE and GTK Debug builds after r243049
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: InRadar
Depends on:
Reported: 2019-03-17 04:26 PDT by Diego Pino
Modified: 2019-03-17 18:05 PDT (History)
7 users (show)

See Also:

Patch (1.28 KB, patch)
2019-03-17 04:27 PDT, Diego Pino
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Pino 2019-03-17 04:26:21 PDT
Fix WPE and GTK Debug builds after r243049
Comment 1 Diego Pino 2019-03-17 04:27:53 PDT
Created attachment 364962 [details]
Comment 2 WebKit Commit Bot 2019-03-17 05:06:54 PDT
Comment on attachment 364962 [details]

Clearing flags on attachment: 364962

Committed r243052: <https://trac.webkit.org/changeset/243052>
Comment 3 WebKit Commit Bot 2019-03-17 05:06:55 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2019-03-17 05:08:57 PDT
Comment 5 Mark Lam 2019-03-17 18:05:38 PDT
Comment on attachment 364962 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=364962&action=review

> Source/JavaScriptCore/runtime/StringPrototype.cpp:1822
> +    default:
> +        ASSERT_NOT_REACHED();

How can this be possibly be correct?  Normalization form is an enum class with only the above four values.  Can you please provide details on what the WPE and GTK Debug builds errors are?  This patch would have be r-ed under normal circumstances.