Bug 195859 - Define the type of SVGPropertyOwnerRegistry for all SVG elements
Summary: Define the type of SVGPropertyOwnerRegistry for all SVG elements
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Said Abou-Hallawa
URL:
Keywords: InRadar
Depends on:
Blocks: 191237 195862
  Show dependency treegraph
 
Reported: 2019-03-16 23:44 PDT by Said Abou-Hallawa
Modified: 2019-03-18 16:43 PDT (History)
7 users (show)

See Also:


Attachments
Patch (116.08 KB, patch)
2019-03-16 23:49 PDT, Said Abou-Hallawa
no flags Details | Formatted Diff | Diff
Patch (128.23 KB, patch)
2019-03-18 15:53 PDT, Said Abou-Hallawa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Said Abou-Hallawa 2019-03-16 23:44:05 PDT
SVGPropertyOwnerRegistry will eventually replace SVGAttributeOwnerProxyImpl.
Comment 1 Said Abou-Hallawa 2019-03-16 23:49:24 PDT
Created attachment 364960 [details]
Patch
Comment 2 Simon Fraser (smfr) 2019-03-18 13:28:48 PDT
Comment on attachment 364960 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364960&action=review

> Source/WebCore/svg/SVGFEBlendElement.h:71
> +    using PropertyRegistry = SVGPropertyOwnerRegistry<SVGFEBlendElement, SVGFilterPrimitiveStandardAttributes>;
> +    const SVGPropertyRegistry& propertyRegistry() const final { return m_propertyRegistry; }
> +
> +    static bool isKnownAttribute(const QualifiedName& attributeName)
> +    {
> +        return AttributeOwnerProxy::isKnownAttribute(attributeName) || PropertyRegistry::isKnownAttribute(attributeName);
> +    }

Lots of classes have this same boilerplate. Can it be pushed to a base class?
Comment 3 Said Abou-Hallawa 2019-03-18 15:35:36 PDT
Comment on attachment 364960 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364960&action=review

>> Source/WebCore/svg/SVGFEBlendElement.h:71
>> +    }
> 
> Lots of classes have this same boilerplate. Can it be pushed to a base class?

It is a static function which uses different types of AttributeOwnerProxy and PropertyRegistry so it can't be virtual. But it will go away once the tear-off objects are removed.
Comment 4 Said Abou-Hallawa 2019-03-18 15:53:16 PDT
Created attachment 365083 [details]
Patch
Comment 5 WebKit Commit Bot 2019-03-18 16:33:17 PDT
Comment on attachment 365083 [details]
Patch

Clearing flags on attachment: 365083

Committed r243114: <https://trac.webkit.org/changeset/243114>
Comment 6 WebKit Commit Bot 2019-03-18 16:33:18 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2019-03-18 16:43:31 PDT
<rdar://problem/48999640>