Bug 195857 - ASSERT(gestureRecognizer == _doubleTapGestureRecognizer) in _doubleTapDidFail:
Summary: ASSERT(gestureRecognizer == _doubleTapGestureRecognizer) in _doubleTapDidFail:
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-16 14:37 PDT by Dean Jackson
Modified: 2019-03-16 15:04 PDT (History)
2 users (show)

See Also:

Attachments
Patch (2.53 KB, patch)
2019-03-16 14:42 PDT, Dean Jackson 		wenson_hsieh: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2019-03-16 14:37:30 PDT 
ASSERT(gestureRecognizer == _doubleTapGestureRecognizer) in _doubleTapDidFail:
Comment 1 Dean Jackson 2019-03-16 14:38:02 PDT 
<rdar://problem/48954679>
Comment 2 Dean Jackson 2019-03-16 14:42:19 PDT 
Created attachment 364942 [details]
Patch
Comment 3 Wenson Hsieh 2019-03-16 14:47:41 PDT 
Comment on attachment 364942 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364942&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:652
> +        [_doubleTapGestureRecognizer setGestureFailedTarget:self action:nil];

Nit - Is there a reason we prefer setting the target to self instead of nil?
Comment 4 Dean Jackson 2019-03-16 15:04:35 PDT 
Committed r243047: <https://trac.webkit.org/changeset/243047>