Bug 195855 – [MSE][GStreamer] Fix handling of resolution changes in AppendPipeline

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Alicia Boya García]

MediaSample instances produced by the AppendPipeline were not accounting for resolution changes. The causes of this are twofold:

1) m_presentationSize is set by connectDemuxerSrcPadToAppsink() (by calling parseDemuxerSrcPadCaps()), but not by appsinkCapsChanged().
2) appsinkCapsChanged() was being called in the main thread as an asynchronous task. In consequence, even if m_presentationSize is set there, many samples with the new resolution would still be wrapped in a MediaSampleGStreamer using the old resolution by the main thread running consumeAppsinkAvailableSamples() before appsinkCapsChanged() is dispatched.

This patch fixes these problems by updating m_presentationSize in appsinkCapsChanged() and making the streaming thread block until the main thread has dispatched appsinkCapsChanged(). This way the handling of caps changes is serialized with the handling of frames.

[Alicia Boya García]

Created attachment 364952 [details]
Patch

[EWS Watchlist]

Comment on attachment 364952 [details]
Patch

Attachment 364952 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/11537034

New failing tests:
media/media-source/media-source-samples-resolution-change.html

[EWS Watchlist]

Created attachment 364954 [details]
Archive of layout-test-results from ews104 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 364952 [details]
Patch

Attachment 364952 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/11537090

New failing tests:
media/media-source/media-source-samples-resolution-change.html

[EWS Watchlist]

Created attachment 364955 [details]
Archive of layout-test-results from ews100 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 364952 [details]
Patch

Attachment 364952 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/11537137

New failing tests:
media/media-source/media-source-samples-resolution-change.html

[EWS Watchlist]

Created attachment 364956 [details]
Archive of layout-test-results from ews115 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[Alicia Boya García]

Created attachment 364964 [details]
Patch

[EWS Watchlist]

Comment on attachment 364964 [details]
Patch

Attachment 364964 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/11541407

New failing tests:
media/media-source/media-source-samples-resolution-change.html

[EWS Watchlist]

Created attachment 364967 [details]
Archive of layout-test-results from ews101 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 364964 [details]
Patch

Attachment 364964 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/11541422

New failing tests:
media/media-source/media-source-samples-resolution-change.html

[EWS Watchlist]

Created attachment 364968 [details]
Archive of layout-test-results from ews105 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 364964 [details]
Patch

Attachment 364964 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/11541459

New failing tests:
media/media-source/media-source-samples-resolution-change.html

[EWS Watchlist]

Created attachment 364969 [details]
Archive of layout-test-results from ews116 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[Xabier Rodríguez Calvar]

Comment on attachment 364964 [details]
Patch

It looks like you need to flag the test for mac.

[Xabier Rodríguez Calvar]

And another comment, could you try to write this test in the W3C test suite and then backport it here?

[Alicia Boya García]

Unfortunately no. This test uses WebKit `internals` methods that are only available in WebKit test runner.

[Alicia Boya García]

(and there is no standard APIs to poke in these internals)

[Alicia Boya García]

Created attachment 365152 [details]
Patch

[EWS Watchlist]

Comment on attachment 365152 [details]
Patch

Attachment 365152 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/11565758

New failing tests:
media/media-source/media-source-samples-resolution-change.html

[EWS Watchlist]

Created attachment 365158 [details]
Archive of layout-test-results from ews103 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 365152 [details]
Patch

Attachment 365152 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/11565832

New failing tests:
media/media-source/media-source-samples-resolution-change.html

[EWS Watchlist]

Created attachment 365160 [details]
Archive of layout-test-results from ews106 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6

[EWS Watchlist]

Comment on attachment 365152 [details]
Patch

Attachment 365152 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/11565864

New failing tests:
media/media-source/media-source-samples-resolution-change.html

[EWS Watchlist]

Created attachment 365166 [details]
Archive of layout-test-results from ews112 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[Alicia Boya García]

Created attachment 365167 [details]
Patch

[EWS Watchlist]

Comment on attachment 365167 [details]
Patch

Attachment 365167 [details] did not pass win-ews (win):
Output: https://webkit-queues.webkit.org/results/11567380

New failing tests:
storage/indexeddb/modern/gc-closes-database-private.html

[EWS Watchlist]

Created attachment 365184 [details]
Archive of layout-test-results from ews204 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: ews204  Port: win-future  Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit

[Alicia Boya García]

Created attachment 365213 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 365213 [details]
Patch

Clearing flags on attachment: 365213

Committed r243199: <https://trac.webkit.org/changeset/243199>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.