Bug 195852 - REGRESSION (r242807): Unified sources build failure from missing imports
Summary: REGRESSION (r242807): Unified sources build failure from missing imports
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-16 10:35 PDT by Timothy Hatcher
Modified: 2019-03-16 11:39 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.43 KB, patch)
2019-03-16 10:40 PDT, Timothy Hatcher
no flags Details | Formatted Diff | Diff
Patch (1.45 KB, patch)
2019-03-16 11:00 PDT, Timothy Hatcher
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2019-03-16 10:35:28 PDT
/Volumes/Data/EWS/WebKit/WebKitBuild/WebKit.build/Release-iphonesimulator/WebKit.build/Objects-normal/x86_64/UnifiedSource32-mm.o
In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release-iphonesimulator/DerivedSources/WebKit2/unified-sources/UnifiedSource32-mm.mm:1:
/Volumes/Data/EWS/WebKit/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:82:1: error: unknown type name 'SOFT_LINK_PRIVATE_FRAMEWORK'
SOFT_LINK_PRIVATE_FRAMEWORK(BackBoardServices)
^
/Volumes/Data/EWS/WebKit/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:82:47: error: expected ';' after top level declarator
SOFT_LINK_PRIVATE_FRAMEWORK(BackBoardServices)
                                              ^
                                              ;
/Volumes/Data/EWS/WebKit/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:393:12: error: use of undeclared identifier 'BKSDisplayBrightnessGetCurrent'
    return BKSDisplayBrightnessGetCurrent();
           ^
/Volumes/Data/EWS/WebKit/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:399:76: error: use of undeclared identifier 'BKSDisplayBrightnessGetCurrent'
    pool->sendToAllProcesses(Messages::WebProcess::BacklightLevelDidChange(BKSDisplayBrightnessGetCurrent()));
                                                                           ^
/Volumes/Data/EWS/WebKit/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:450:146: error: use of undeclared identifier 'UIBacklightLevelChangedNotification'
    CFNotificationCenterAddObserver(CFNotificationCenterGetDarwinNotifyCenter(), this, backlightLevelDidChangeCallback, static_cast<CFStringRef>(UIBacklightLevelChangedNotification), nullptr, CFNotificationSuspensionBehaviorCoalesce);
                                                                                                                                                 ^
/Volumes/Data/EWS/WebKit/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm:473:116: error: use of undeclared identifier 'UIBacklightLevelChangedNotification'
    CFNotificationCenterRemoveObserver(CFNotificationCenterGetDarwinNotifyCenter(), this, static_cast<CFStringRef>(UIBacklightLevelChangedNotification) , nullptr);
                                                                                                                   ^
6 errors generated.
Comment 1 Timothy Hatcher 2019-03-16 10:40:27 PDT
Created attachment 364935 [details]
Patch
Comment 2 Timothy Hatcher 2019-03-16 11:00:55 PDT
Created attachment 364936 [details]
Patch
Comment 3 WebKit Commit Bot 2019-03-16 11:38:51 PDT
Comment on attachment 364936 [details]
Patch

Clearing flags on attachment: 364936

Committed r243042: <https://trac.webkit.org/changeset/243042>
Comment 4 WebKit Commit Bot 2019-03-16 11:38:53 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-03-16 11:39:19 PDT
<rdar://problem/48954938>