RESOLVED FIXED 195840
[JSC] jsSubstring should resolve rope before calling JSRopeString::create 
https://bugs.webkit.org/show_bug.cgi?id=195840
Summary [JSC] jsSubstring should resolve rope before calling JSRopeString::create
Yusuke Suzuki
Reported 2019-03-15 18:07:57 PDT
[JSC] jsSubstring should resolve rope before calling JSRopeString::create
Attachments
Patch (25.95 KB, patch)
2019-03-15 18:15 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (26.10 KB, patch)
2019-03-15 18:23 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (27.49 KB, patch)
2019-03-15 18:27 PDT, Yusuke Suzuki 		ggaren: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2019-03-15 18:15:56 PDT
Created attachment 364895 [details] Patch
Yusuke Suzuki
Comment 2 2019-03-15 18:23:44 PDT
Created attachment 364898 [details] Patch
Yusuke Suzuki
Comment 3 2019-03-15 18:27:06 PDT
Created attachment 364899 [details] Patch
Geoffrey Garen
Comment 4 2019-03-16 13:59:54 PDT
Comment on attachment 364899 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364899&action=review r=me > Source/JavaScriptCore/ChangeLog:13 > + We can find that a lot of substrings for length = 1 are allocated in RAMification regexp tests. This patch avoids creation of these How much memory does this patch save?
Yusuke Suzuki
Comment 5 2019-03-17 15:14:20 PDT
Comment on attachment 364899 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364899&action=review >> Source/JavaScriptCore/ChangeLog:13 >> + We can find that a lot of substrings for length = 1 are allocated in RAMification regexp tests. This patch avoids creation of these > > How much memory does this patch save? It shows (patched) 34938880 v.s. (tot) 36163584 in non-JIT regexp, 3.5%.
Yusuke Suzuki
Comment 6 2019-03-18 10:50:53 PDT
Committed r243081: <https://trac.webkit.org/changeset/243081>
Radar WebKit Bug Importer
Comment 7 2019-03-18 10:51:28 PDT
<rdar://problem/48984367>
Note You need to log in before you can comment on or make changes to this bug.