Bug 195839 - [iOS] Calling preventDefault() when handling a pointerdown event should not prevent panning, zooming or click event dispatch
Summary: [iOS] Calling preventDefault() when handling a pointerdown event should not p...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-15 17:47 PDT by Antoine Quint
Modified: 2019-04-24 13:24 PDT (History)
7 users (show)

See Also:

Attachments
Patch (11.32 KB, patch)
2019-04-24 08:39 PDT, Antoine Quint 		bfulgham: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2019-03-15 17:47:36 PDT 
Calling preventDefault() when handling a pointerdown event should not prevent a future click event for that user interaction.
Comment 1 Radar WebKit Bug Importer 2019-03-15 17:47:52 PDT 
<rdar://problem/48946154>
Comment 2 Antoine Quint 2019-04-24 08:39:22 PDT 
Created attachment 368127 [details]
Patch
Comment 3 Daniel Bates 2019-04-24 09:04:43 PDT 
Title does not make sense. Description (comment #0) makes sense
Comment 4 Antoine Quint 2019-04-24 09:34:54 PDT 
(In reply to Daniel Bates from comment #3)
> Title does not make sense. Description (comment #0) makes sense

Actually, it should be a mix of both :) I'll update the title.
Comment 5 Brent Fulgham 2019-04-24 10:24:41 PDT 
The api-ios failure is because the bot needs a clean build (see Alan's e-mail):

please delete /Debug-iphonesimulator/DerivedSources/WebKitLegacy/WebKitLegacy.generated.exp (or alternatively trigger a clean build).
Comment 6 Brent Fulgham 2019-04-24 10:34:27 PDT 
Comment on attachment 368127 [details]
Patch

Great!
Comment 7 Antoine Quint 2019-04-24 11:00:35 PDT 
Committed r244598: <https://trac.webkit.org/changeset/244598>
Comment 8 Daniel Bates 2019-04-24 13:24:03 PDT 
(In reply to Brent Fulgham from comment #5)
> The api-ios failure is because the bot needs a clean build (see Alan's
> e-mail):
> 
> please delete
> /Debug-iphonesimulator/DerivedSources/WebKitLegacy/WebKitLegacy.generated.
> exp (or alternatively trigger a clean build).

Filed bug #197241 for this.