RESOLVED FIXED19583
Use tabIndex in the Web Inspector for focusable areas 
https://bugs.webkit.org/show_bug.cgi?id=19583
Summary Use tabIndex in the Web Inspector for focusable areas
Timothy Hatcher
Reported 2008-06-16 09:44:50 PDT
The Web Inspector has it's own code for marking and tracking focusable areas. We should sue tabIndex now that it can focus any element.
Attachments
Proposed patch (21.27 KB, patch)
2008-06-16 11:34 PDT, Timothy Hatcher 		aroben: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Timothy Hatcher
Comment 1 2008-06-16 09:45:05 PDT
I have a fix for this.
Timothy Hatcher
Comment 2 2008-06-16 11:34:51 PDT
Created attachment 21737 [details] Proposed patch
Adam Roben (:aroben)
Comment 3 2008-06-17 13:50:14 PDT
Comment on attachment 21737 [details] Proposed patch - if (WebInspector.currentFocusElement === this.messagesElement) - WebInspector.currentFocusElement = this._previousFocusElement; - delete this._previousFocusElement; + if (this.element === WebInspector.currentFocusElement || this.element.isAncestor(WebInspector.currentFocusElement)) + WebInspector.currentFocusElement = WebInspector.previousFocusElement; This seems like a change in behavior. You do a similar check at the end of this patch. Can you explain it in the ChangeLog? r=me
Timothy Hatcher
Comment 4 2008-06-17 15:34:12 PDT
Landed in r34631.
Note You need to log in before you can comment on or make changes to this bug.