Bug 195828 - Web Inspector: Canvas: rework how Canvas.enable/Canvas.disable is used so that events are not sent when the Canvas tab isn't enabled
Summary: Web Inspector: Canvas: rework how Canvas.enable/Canvas.disable is used so tha...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks: WebInspectorCanvasTab
  Show dependency treegraph
 
Reported: 2019-03-15 15:43 PDT by Devin Rousso
Modified: 2019-03-20 19:27 PDT (History)
7 users (show)

See Also:


Attachments
Patch (4.11 KB, patch)
2019-03-15 15:50 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff
Patch (4.25 KB, patch)
2019-03-15 15:52 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-highsierra (3.44 MB, application/zip)
2019-03-15 16:39 PDT, Build Bot
no flags Details
Patch (4.80 KB, patch)
2019-03-15 17:07 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2019-03-15 15:43:07 PDT
If the Canvas tab isn't even "on", we shouldn't send any events to the frontend.
Comment 1 Radar WebKit Bug Importer 2019-03-15 15:43:24 PDT
<rdar://problem/48941756>
Comment 2 Devin Rousso 2019-03-15 15:50:51 PDT
Created attachment 364860 [details]
Patch
Comment 3 Devin Rousso 2019-03-15 15:52:33 PDT
Created attachment 364861 [details]
Patch

Forgot to clear the maps :(
Comment 4 Build Bot 2019-03-15 16:39:17 PDT Comment hidden (obsolete)
Comment 5 Build Bot 2019-03-15 16:39:18 PDT Comment hidden (obsolete)
Comment 6 Devin Rousso 2019-03-15 17:07:23 PDT
Created attachment 364883 [details]
Patch
Comment 7 WebKit Commit Bot 2019-03-20 19:27:40 PDT
Comment on attachment 364883 [details]
Patch

Clearing flags on attachment: 364883

Committed r243272: <https://trac.webkit.org/changeset/243272>
Comment 8 WebKit Commit Bot 2019-03-20 19:27:42 PDT
All reviewed patches have been landed.  Closing bug.