195828 – Web Inspector: Canvas: rework how Canvas.enable/Canvas.disable is used so that events are not sent when the Canvas tab isn't enabled

RESOLVED FIXED Bug 195828

Web Inspector: Canvas: rework how Canvas.enable/Canvas.disable is used so that events are not sent when the Canvas tab isn't enabled

https://bugs.webkit.org/show_bug.cgi?id=195828

Summary Web Inspector: Canvas: rework how Canvas.enable/Canvas.disable is used so tha...

Devin Rousso

Reported 2019-03-15 15:43:07 PDT

If the Canvas tab isn't even "on", we shouldn't send any events to the frontend.

Attachments
Patch (4.11 KB, patch) 2019-03-15 15:50 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Patch (4.25 KB, patch) 2019-03-15 15:52 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews103 for mac-highsierra (3.44 MB, application/zip) 2019-03-15 16:39 PDT, EWS Watchlist	no flags	Details
Patch (4.80 KB, patch) 2019-03-15 17:07 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2019-03-15 15:43:24 PDT

<rdar://problem/48941756>

Devin Rousso

Comment 2 2019-03-15 15:50:51 PDT

Created attachment 364860 [details] Patch

Devin Rousso

Comment 3 2019-03-15 15:52:33 PDT

Created attachment 364861 [details] Patch Forgot to clear the maps :(

EWS Watchlist

Comment 4 2019-03-15 16:39:17 PDT Comment hidden (obsolete)

Comment on attachment 364861 [details] Patch Attachment 364861 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/11524049 New failing tests: inspector/canvas/setRecordingAutoCaptureFrameCount.html inspector/canvas/resolveCanvasContext-bitmaprenderer.html inspector/canvas/recording-2d.html inspector/canvas/recording-webgl.html inspector/canvas/requestContent-webgl2.html inspector/canvas/updateShader.html inspector/canvas/resolveCanvasContext-webgl2.html inspector/canvas/resolveCanvasContext-webmetal.html inspector/canvas/create-context-bitmaprenderer.html inspector/canvas/resolveCanvasContext-2d.html inspector/canvas/setShaderProgramDisabled.html inspector/canvas/extensions.html inspector/canvas/recording-bitmaprenderer.html inspector/canvas/resolveCanvasContext-webgl.html inspector/canvas/requestContent-webgl.html inspector/canvas/requestContent-2d.html inspector/canvas/create-context-webgl.html inspector/canvas/recording.html inspector/canvas/setShaderProgramHighlighted.html inspector/canvas/recording-webgl-snapshots.html inspector/canvas/requestShaderSource.html inspector/canvas/memory.html inspector/canvas/requestContent-bitmaprenderer.html inspector/canvas/requestNode.html

EWS Watchlist

Comment 5 2019-03-15 16:39:18 PDT Comment hidden (obsolete)

Created attachment 364877 [details] Archive of layout-test-results from ews103 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-highsierra Platform: Mac OS X 10.13.6

Devin Rousso

Comment 6 2019-03-15 17:07:23 PDT

Created attachment 364883 [details] Patch

WebKit Commit Bot

Comment 7 2019-03-20 19:27:40 PDT

Comment on attachment 364883 [details] Patch Clearing flags on attachment: 364883 Committed r243272: <https://trac.webkit.org/changeset/243272>

WebKit Commit Bot

Comment 8 2019-03-20 19:27:42 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version WebKit Nightly Build

Hardware All

OS All

Product WebKit

Component Web Inspector

Assignee

Devin Rousso

Reported

2019-03-15 15:43 PDT

Modified

2019-03-20 19:27 PDT History

CC List

7 users Show

URL

Keywords InRadar

Depends on

Blocks

WebInspectorCanvasTab

Dependancies

tree graph