Bug 195826 - [iOS] Modalify <select> popover; app key commands should not be recognized when popover is open
Summary: [iOS] Modalify <select> popover; app key commands should not be recognized wh...
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Local Build
Hardware: iPhone / iPad iOS 12
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar, PlatformOnly
Depends on:
Blocks:
 
Reported: 2019-03-15 15:23 PDT by Daniel Bates
Modified: 2019-03-19 12:43 PDT (History)
4 users (show)

See Also:

Attachments
Patch (9.23 KB, patch)
2019-03-15 16:02 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
Patch (9.17 KB, patch)
2019-03-15 16:06 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2019-03-15 15:23:14 PDT 
Seen on iPad.

Steps to reproduce:

1. Visit <data:text/html,<select><option>First</option><option>Second</option></select>>.
2. Tap the popup button to open the popover.
3. Press Command + r.

Safari reloads the page! But that is not intuitive and does not match the Mac. Instead the popover should behave like a modal and all key events should go it or we need to make the illusions of this.
Comment 1 Radar WebKit Bug Importer 2019-03-15 15:38:00 PDT 
<rdar://problem/48941551>
Comment 2 Daniel Bates 2019-03-15 16:02:57 PDT 
Created attachment 364871 [details]
Patch
Comment 3 Daniel Bates 2019-03-15 16:06:36 PDT 
Created attachment 364874 [details]
Patch
Comment 4 Brent Fulgham 2019-03-18 21:23:07 PDT 
Comment on attachment 364874 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364874&action=review

Did we still want to do this? From our earlier discussion I thought modal select was not the desired UI?

> Source/WebKit/ChangeLog:8
> +        Fake it til you make it ð Add a hack to give the illusion that popovers are modal and all

Did you mean to include that non-ASCII character in this line?
Comment 5 Daniel Bates 2019-03-19 11:26:52 PDT 
Comment on attachment 364874 [details]
Patch

No need to fake what you won't make.😀
Comment 6 Brent Fulgham 2019-03-19 12:43:17 PDT 
We decided not to modality <select>.