Bug 195811 – [WHLSL] Remove traps from the compiler

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGPU

[Myles C. Maxfield]

Implement traps

[Myles C. Maxfield]

This should include traps that are generated by indexing off the end of an array, etc.

[Radar WebKit Bug Importer]

<rdar://problem/50746299>

[Robin Morisset]

We have decided to remove traps from the language, see https://github.com/gpuweb/WHLSL/issues/301.

[Robin Morisset]

Created attachment 374128 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 374128 [details]
Patch

Rejecting attachment 374128 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 374128, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=374128&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=195811&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Processing patch 374128 from bug 195811.
Fetching: https://bugs.webkit.org/attachment.cgi?id=374128
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Myles C. Maxfield']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 15 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLAST.h
patching file Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLStatement.h
Hunk #1 succeeded at 60 with fuzz 2.
patching file Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLTrap.h
rm 'Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLTrap.h'
patching file Source/WebCore/Modules/webgpu/WHLSL/Metal/WHLSLFunctionWriter.cpp
Hunk #1 succeeded at 126 with fuzz 2 (offset 2 lines).
Hunk #2 succeeded at 400 (offset -14 lines).
patching file Source/WebCore/Modules/webgpu/WHLSL/WHLSLASTDumper.cpp
Hunk #1 succeeded at 486 (offset -16 lines).
patching file Source/WebCore/Modules/webgpu/WHLSL/WHLSLASTDumper.h
Hunk #1 succeeded at 98 with fuzz 2.
patching file Source/WebCore/Modules/webgpu/WHLSL/WHLSLLexer.cpp
patching file Source/WebCore/Modules/webgpu/WHLSL/WHLSLLexer.h
patching file Source/WebCore/Modules/webgpu/WHLSL/WHLSLParser.cpp
Hunk #1 succeeded at 1303 (offset 3 lines).
patching file Source/WebCore/Modules/webgpu/WHLSL/WHLSLParser.h
patching file Source/WebCore/Modules/webgpu/WHLSL/WHLSLStatementBehaviorChecker.cpp
Hunk #1 succeeded at 41 with fuzz 1.
Hunk #2 succeeded at 88 (offset -1 lines).
patching file Source/WebCore/Modules/webgpu/WHLSL/WHLSLVisitor.cpp
Hunk #1 FAILED at 329.
Hunk #2 succeeded at 458 (offset -7 lines).
1 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/Modules/webgpu/WHLSL/WHLSLVisitor.cpp.rej
patching file Source/WebCore/Modules/webgpu/WHLSL/WHLSLVisitor.h
Hunk #1 succeeded at 83 with fuzz 2.
Hunk #2 succeeded at 162 with fuzz 2 (offset -1 lines).
patching file Source/WebCore/WebCore.xcodeproj/project.pbxproj
Hunk #1 succeeded at 13240 (offset -48 lines).
Hunk #2 succeeded at 17115 (offset -65 lines).

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Myles C. Maxfield']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: https://webkit-queues.webkit.org/results/12753939

[Robin Morisset]

Created attachment 374343 [details]
Patch

rebased.

[WebKit Commit Bot]

Comment on attachment 374343 [details]
Patch

Rejecting attachment 374343 [details] from commit-queue.

New failing tests:
storage/indexeddb/dont-wedge.html
Full output: https://webkit-queues.webkit.org/results/12762042

[WebKit Commit Bot]

Created attachment 374352 [details]
Archive of layout-test-results from webkit-cq-01 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-01  Port: mac-highsierra  Platform: Mac OS X 10.13.6

[Robin Morisset]

Comment on attachment 374343 [details]
Patch

Trying again since I don't see any reason I could have broken this particular test, and some other patch had the same error a couple hours ago.

[WebKit Commit Bot]

Comment on attachment 374343 [details]
Patch

Clearing flags on attachment: 374343

Committed r247551: <https://trac.webkit.org/changeset/247551>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.