Bug 195811 - [WHLSL] Remove traps from the compiler
Summary: [WHLSL] Remove traps from the compiler
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Robin Morisset
Keywords: InRadar
Depends on:
Reported: 2019-03-15 11:49 PDT by Myles C. Maxfield
Modified: 2019-07-17 18:19 PDT (History)
3 users (show)

See Also:

Patch (14.64 KB, patch)
2019-07-15 11:33 PDT, Robin Morisset
mmaxfield: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Patch (14.69 KB, patch)
2019-07-17 15:41 PDT, Robin Morisset
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-cq-01 for mac-highsierra (3.22 MB, application/zip)
2019-07-17 17:01 PDT, WebKit Commit Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2019-03-15 11:49:52 PDT
Implement traps
Comment 1 Myles C. Maxfield 2019-03-15 11:50:20 PDT
This should include traps that are generated by indexing off the end of an array, etc.
Comment 2 Radar WebKit Bug Importer 2019-05-13 17:07:56 PDT
Comment 3 Robin Morisset 2019-07-15 10:29:27 PDT
We have decided to remove traps from the language, see https://github.com/gpuweb/WHLSL/issues/301.
Comment 4 Robin Morisset 2019-07-15 11:33:33 PDT
Created attachment 374128 [details]
Comment 5 WebKit Commit Bot 2019-07-16 15:35:55 PDT
Comment on attachment 374128 [details]

Rejecting attachment 374128 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 374128, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as commit-queue@webkit.org...
Fetching: https://bugs.webkit.org/attachment.cgi?id=374128&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=195811&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Processing patch 374128 from bug 195811.
Fetching: https://bugs.webkit.org/attachment.cgi?id=374128
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Myles C. Maxfield']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 15 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLAST.h
patching file Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLStatement.h
Hunk #1 succeeded at 60 with fuzz 2.
patching file Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLTrap.h
rm 'Source/WebCore/Modules/webgpu/WHLSL/AST/WHLSLTrap.h'
patching file Source/WebCore/Modules/webgpu/WHLSL/Metal/WHLSLFunctionWriter.cpp
Hunk #1 succeeded at 126 with fuzz 2 (offset 2 lines).
Hunk #2 succeeded at 400 (offset -14 lines).
patching file Source/WebCore/Modules/webgpu/WHLSL/WHLSLASTDumper.cpp
Hunk #1 succeeded at 486 (offset -16 lines).
patching file Source/WebCore/Modules/webgpu/WHLSL/WHLSLASTDumper.h
Hunk #1 succeeded at 98 with fuzz 2.
patching file Source/WebCore/Modules/webgpu/WHLSL/WHLSLLexer.cpp
patching file Source/WebCore/Modules/webgpu/WHLSL/WHLSLLexer.h
patching file Source/WebCore/Modules/webgpu/WHLSL/WHLSLParser.cpp
Hunk #1 succeeded at 1303 (offset 3 lines).
patching file Source/WebCore/Modules/webgpu/WHLSL/WHLSLParser.h
patching file Source/WebCore/Modules/webgpu/WHLSL/WHLSLStatementBehaviorChecker.cpp
Hunk #1 succeeded at 41 with fuzz 1.
Hunk #2 succeeded at 88 (offset -1 lines).
patching file Source/WebCore/Modules/webgpu/WHLSL/WHLSLVisitor.cpp
Hunk #1 FAILED at 329.
Hunk #2 succeeded at 458 (offset -7 lines).
1 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/Modules/webgpu/WHLSL/WHLSLVisitor.cpp.rej
patching file Source/WebCore/Modules/webgpu/WHLSL/WHLSLVisitor.h
Hunk #1 succeeded at 83 with fuzz 2.
Hunk #2 succeeded at 162 with fuzz 2 (offset -1 lines).
patching file Source/WebCore/WebCore.xcodeproj/project.pbxproj
Hunk #1 succeeded at 13240 (offset -48 lines).
Hunk #2 succeeded at 17115 (offset -65 lines).

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Myles C. Maxfield']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: https://webkit-queues.webkit.org/results/12753939
Comment 6 Robin Morisset 2019-07-17 15:41:17 PDT
Created attachment 374343 [details]

Comment 7 WebKit Commit Bot 2019-07-17 17:01:14 PDT
Comment on attachment 374343 [details]

Rejecting attachment 374343 [details] from commit-queue.

New failing tests:
Full output: https://webkit-queues.webkit.org/results/12762042
Comment 8 WebKit Commit Bot 2019-07-17 17:01:15 PDT
Created attachment 374352 [details]
Archive of layout-test-results from webkit-cq-01 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-01  Port: mac-highsierra  Platform: Mac OS X 10.13.6
Comment 9 Robin Morisset 2019-07-17 17:38:06 PDT
Comment on attachment 374343 [details]

Trying again since I don't see any reason I could have broken this particular test, and some other patch had the same error a couple hours ago.
Comment 10 WebKit Commit Bot 2019-07-17 18:19:01 PDT
Comment on attachment 374343 [details]

Clearing flags on attachment: 374343

Committed r247551: <https://trac.webkit.org/changeset/247551>
Comment 11 WebKit Commit Bot 2019-07-17 18:19:03 PDT
All reviewed patches have been landed.  Closing bug.