Bug 195782 – Remove retain cycle from JSScript and also don't keep the cache file descriptor open so many JSScripts can be cached in a loop

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Saam Barati]

This will address feedback of folks trying to use this API.

[Saam Barati]

<rdar://problem/48880625>

[Saam Barati]

Created attachment 364726 [details]
patch

[EWS Watchlist]

Attachment 364726 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/API/tests/testapi.mm:2205:  One line control clauses should not use braces.  [whitespace/braces] [4]
ERROR: Source/JavaScriptCore/API/tests/testapi.mm:2237:  One line control clauses should not use braces.  [whitespace/braces] [4]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Michael Saboff]

Comment on attachment 364726 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364726&action=review

r=me

> Source/JavaScriptCore/API/JSScript.mm:290
> +        error = "No cache was path provided during construction of this JSScript."_s;

I know you didn't change this error message, but shouldn't it read "No cache *path was* provided during construction of this JSScript."?

[Saam Barati]

Comment on attachment 364726 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364726&action=review

>> Source/JavaScriptCore/API/JSScript.mm:290
>> +        error = "No cache was path provided during construction of this JSScript."_s;
> 
> I know you didn't change this error message, but shouldn't it read "No cache *path was* provided during construction of this JSScript."?

Yeah will fix.

[Saam Barati]

Created attachment 364743 [details]
patch for landing

[Saam Barati]

landed in:
https://trac.webkit.org/changeset/242980/webkit