Bug 195781 - [Web GPU] GPUAdapter.createDevice -> GPUAdapter.requestDevice
Summary: [Web GPU] GPUAdapter.createDevice -> GPUAdapter.requestDevice
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Justin Fan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-14 16:40 PDT by Justin Fan
Modified: 2019-03-18 12:19 PDT (History)
9 users (show)

See Also:

Attachments
Patch (11.61 KB, patch)
2019-03-14 16:56 PDT, Justin Fan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Fan 2019-03-14 16:40:31 PDT 
[Web GPU] GPUAdapter.createDevice -> GPUAdapter.requestDevice
Comment 1 Justin Fan 2019-03-14 16:56:26 PDT 
Created attachment 364720 [details]
Patch
Comment 2 Myles C. Maxfield 2019-03-14 17:00:38 PDT 
Comment on attachment 364720 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364720&action=review

> Source/WebCore/Modules/webgpu/WebGPUAdapter.cpp:49
> +        promise.resolve(device.releaseNonNull());

Are you sure that releaseNonNull is the right thing here?
Comment 3 WebKit Commit Bot 2019-03-18 12:18:56 PDT 
Comment on attachment 364720 [details]
Patch

Clearing flags on attachment: 364720

Committed r243090: <https://trac.webkit.org/changeset/243090>
Comment 4 WebKit Commit Bot 2019-03-18 12:18:58 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-03-18 12:19:17 PDT 
<rdar://problem/48988528>