Bug 195780 - Make it possible to test scrolling tree layer manipulation more easily
Summary: Make it possible to test scrolling tree layer manipulation more easily
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks: 195733
  Show dependency tree / graph
 
Reported: 2019-03-14 16:13 PDT by Simon Fraser (smfr)
Modified: 2019-03-14 18:52 PDT (History)
7 users (show)

See Also:

Attachments
Patch (19.43 KB, patch)
2019-03-14 16:16 PDT, Simon Fraser (smfr) 		thorton: review+
Details | Formatted Diff | Diff
Patch (20.23 KB, patch)
2019-03-14 16:33 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2019-03-14 16:13:19 PDT 
Make it possible to test scrolling tree layer manipulation more easily
Comment 1 Simon Fraser (smfr) 2019-03-14 16:16:57 PDT 
Created attachment 364711 [details]
Patch
Comment 2 Tim Horton 2019-03-14 16:25:28 PDT 
Comment on attachment 364711 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364711&action=review

> Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h:64
> +@property (nonatomic, setter=_setScrollingUpdatesDisabledForTesting:) BOOL _scrollingUpdatesDisabledForTesting;

Shouldn't need this?

> Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:51
> +    BOOL m_scrollingUpdatesDisabled;

No m_ for ObjC ivars
Comment 3 Tim Horton 2019-03-14 16:25:52 PDT 
Comment on attachment 364711 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364711&action=review

>> Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:51
>> +    BOOL m_scrollingUpdatesDisabled;
> 
> No m_ for ObjC ivars

to be clear, you keep the _
Comment 4 Simon Fraser (smfr) 2019-03-14 16:33:27 PDT 
Created attachment 364716 [details]
Patch
Comment 5 WebKit Commit Bot 2019-03-14 18:10:15 PDT 
Comment on attachment 364716 [details]
Patch

Clearing flags on attachment: 364716

Committed r242979: <https://trac.webkit.org/changeset/242979>
Comment 6 Radar WebKit Bug Importer 2019-03-14 18:52:19 PDT 
<rdar://problem/48912027>