Bug 19577 - JSCore does not compile in C++ environments where C99 headers are not present
Summary: JSCore does not compile in C++ environments where C99 headers are not present
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-06-16 06:34 PDT by Simon Hausmann
Modified: 2008-06-16 14:23 PDT (History)
0 users

See Also:


Attachments
Fix compilation in C++ environments where C99 headers are not present (2.52 KB, patch)
2008-06-16 06:35 PDT, Simon Hausmann
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Hausmann 2008-06-16 06:34:24 PDT
Some JSCore public header files include stdbool.h. The stdbool.h header is a C99 feature, defining the "_Bool" type as well as the "true" and "false" constants. But it's completely unnecessary in C++ as the
language already defines the "bool" type and its two values.
Comment 1 Simon Hausmann 2008-06-16 06:35:30 PDT
Created attachment 21725 [details]
Fix compilation in C++ environments where C99 headers are not present

Proposed patch from Thiago Macieira  <tjmaciei@trolltech.com>
Comment 2 Simon Hausmann 2008-06-16 06:39:45 PDT
I think the patch is fine, but since this touches the header files of the public API I'd be great to get a review from someone with experience on handling those :)
Comment 3 Darin Adler 2008-06-16 08:53:35 PDT
Comment on attachment 21725 [details]
Fix compilation in C++ environments where C99 headers are not present

Seems OK. r=me
Comment 4 Simon Hausmann 2008-06-16 14:23:37 PDT
Landed in r34606