Bug 195752 - REGRESSION(r242841): Fix conservative DFG OSR entry validation to accept values which will be stored in AnyInt / Double flush formats
Summary: REGRESSION(r242841): Fix conservative DFG OSR entry validation to accept valu...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-14 11:35 PDT by Yusuke Suzuki
Modified: 2019-03-14 22:46 PDT (History)
6 users (show)

See Also:


Attachments
Patch (17.74 KB, patch)
2019-03-14 11:48 PDT, Yusuke Suzuki
no flags Details | Formatted Diff | Diff
Patch (17.74 KB, patch)
2019-03-14 13:22 PDT, Yusuke Suzuki
sbarati: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2019-03-14 11:35:00 PDT
[JSC] DFG OSR entry tends to reject Double and AnyInt values
Comment 1 Yusuke Suzuki 2019-03-14 11:48:38 PDT
Created attachment 364670 [details]
Patch
Comment 2 Yusuke Suzuki 2019-03-14 13:22:50 PDT
Created attachment 364680 [details]
Patch
Comment 3 Saam Barati 2019-03-14 18:49:09 PDT
Comment on attachment 364680 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364680&action=review

> Source/JavaScriptCore/ChangeLog:3
> +        [JSC] DFG OSR entry tends to reject Double and AnyInt values

nit: this makes it seem like this is a longstanding issue. It's not. It regressed only recently. It'd be good for this title to acknowledge that this just regressed.

> Source/JavaScriptCore/ChangeLog:8
> +        We fix the bug skipping AbstractValue validations when the flush format is Double or AnyInt. But it

you should say what revision.
"fix" => "fixed"
Comment 4 Yusuke Suzuki 2019-03-14 22:41:30 PDT
Comment on attachment 364680 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364680&action=review

Thanks!

>> Source/JavaScriptCore/ChangeLog:3
>> +        [JSC] DFG OSR entry tends to reject Double and AnyInt values
> 
> nit: this makes it seem like this is a longstanding issue. It's not. It regressed only recently. It'd be good for this title to acknowledge that this just regressed.

Sounds nice! I changed the title to "REGRESSION(r242841): Fix conservative DFG OSR entry validation to accept values which will be stored in AnyInt / Double flush formats"

>> Source/JavaScriptCore/ChangeLog:8
>> +        We fix the bug skipping AbstractValue validations when the flush format is Double or AnyInt. But it
> 
> you should say what revision.
> "fix" => "fixed"

Fixed.
Comment 5 Yusuke Suzuki 2019-03-14 22:45:15 PDT
Committed r242990: <https://trac.webkit.org/changeset/242990>
Comment 6 Radar WebKit Bug Importer 2019-03-14 22:46:18 PDT
<rdar://problem/48916051>