Bug 195731 - Device orientation's permission should only require a user gesture to prompt the user
Summary: Device orientation's permission should only require a user gesture to prompt ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 195750
  Show dependency tree / graph
 
Reported: 2019-03-13 19:49 PDT by Chris Dumez
Modified: 2019-03-14 12:22 PDT (History)
10 users (show)

See Also:

Attachments
Patch (12.16 KB, patch)
2019-03-13 19:51 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2019-03-13 19:49:17 PDT 
Device orientation's permission should only require a user gesture to prompt the user. If the user already made a decision, we should resolve the promise with this decision, even without user gesture.
This is useful for JS to figure out if they are access to device orientation or not because showing UI for the user to give permission.
Comment 1 Chris Dumez 2019-03-13 19:51:19 PDT 
Created attachment 364612 [details]
Patch
Comment 2 Chris Dumez 2019-03-14 11:47:08 PDT 
Comment on attachment 364612 [details]
Patch

ping review? This is blocking my next patch.
Comment 3 Geoffrey Garen 2019-03-14 11:55:41 PDT 
Comment on attachment 364612 [details]
Patch

r=me
Comment 4 Chris Dumez 2019-03-14 11:58:03 PDT 
Comment on attachment 364612 [details]
Patch

Clearing flags on attachment: 364612

Committed r242951: <https://trac.webkit.org/changeset/242951>
Comment 5 Chris Dumez 2019-03-14 11:58:04 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2019-03-14 11:59:19 PDT 
<rdar://problem/48895657>