Bug 195726 - Long press gesture recognizers in WKWebView are conflicting with internal gesture recognizers
Summary: Long press gesture recognizers in WKWebView are conflicting with internal ges...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-13 19:19 PDT by James Magahern
Modified: 2019-03-21 18:03 PDT (History)
7 users (show)

See Also:


Attachments
Patch (2.36 KB, patch)
2019-03-13 19:22 PDT, James Magahern
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews200 for win-future (12.90 MB, application/zip)
2019-03-13 22:00 PDT, Build Bot
no flags Details
Patch (2.28 KB, patch)
2019-03-21 15:16 PDT, James Magahern
no flags Details | Formatted Diff | Diff
Patch (3.91 KB, patch)
2019-03-21 16:49 PDT, James Magahern
no flags Details | Formatted Diff | Diff
Patch (2.53 KB, patch)
2019-03-21 16:53 PDT, James Magahern
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Magahern 2019-03-13 19:19:01 PDT
Long press gesture recognizers in WKWebView are conflicting with internal scroll view long press gesture recognizers
Comment 1 James Magahern 2019-03-13 19:22:32 PDT
Created attachment 364609 [details]
Patch
Comment 2 James Magahern 2019-03-13 19:22:34 PDT
<rdar://problem/48582449>
Comment 3 Build Bot 2019-03-13 19:24:38 PDT
Attachment 364609 [details] did not pass style-queue:


ERROR: Source/WebKit/ChangeLog:5:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebKit/ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/WebKit/ChangeLog:10:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 3 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Megan Gardner 2019-03-13 20:21:39 PDT
Comment on attachment 364609 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364609&action=review

You will need to repost a patch with the spaces changes since you do not have committed status on WebKit, but other wise this looks good.

> w/Source/WebKit/ChangeLog:10
> +		canPreventGestureRecognizer whitelist. 

Spaces, not tabs, even in change logs.
Comment 5 Build Bot 2019-03-13 22:00:01 PDT Comment hidden (obsolete)
Comment 6 Build Bot 2019-03-13 22:00:12 PDT Comment hidden (obsolete)
Comment 7 James Magahern 2019-03-21 15:16:50 PDT
Created attachment 365628 [details]
Patch
Comment 8 James Magahern 2019-03-21 15:17:27 PDT
I went ahead and moved all this stuff to WebKitAdditions instead.
Comment 9 James Magahern 2019-03-21 16:49:56 PDT
Created attachment 365645 [details]
Patch
Comment 10 James Magahern 2019-03-21 16:53:55 PDT
Created attachment 365646 [details]
Patch
Comment 11 WebKit Commit Bot 2019-03-21 18:03:24 PDT
Comment on attachment 365646 [details]
Patch

Clearing flags on attachment: 365646

Committed r243351: <https://trac.webkit.org/changeset/243351>
Comment 12 WebKit Commit Bot 2019-03-21 18:03:25 PDT
All reviewed patches have been landed.  Closing bug.