Bug 195718 - _WKDownload should conform to NSCopying protocol
Summary: _WKDownload should conform to NSCopying protocol
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-13 17:35 PDT by Alex Christensen
Modified: 2019-03-15 15:19 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.70 KB, patch)
2019-03-13 17:36 PDT, Alex Christensen
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2019-03-13 17:35:47 PDT
_WKDownload should conform to NSCopying protocol
Comment 1 Alex Christensen 2019-03-13 17:36:45 PDT
Created attachment 364596 [details]
Patch
Comment 2 Tim Horton 2019-03-15 15:13:24 PDT
Comment on attachment 364596 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364596&action=review

> Source/WebKit/UIProcess/API/Cocoa/_WKDownload.mm:88
> +    return [self retain];

copy -> cancel -> cancels the original, I guess that's OK?
Comment 3 Alex Christensen 2019-03-15 15:18:36 PDT
http://trac.webkit.org/r243016
Comment 4 Radar WebKit Bug Importer 2019-03-15 15:19:17 PDT
<rdar://problem/48940660>