[GStreamer][WebRTC]: Refactor to make the encoding happen synchronously
Created attachment 364528 [details] Patch
Comment on attachment 364528 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364528&action=review > Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp:146 > + GST_DEBUG_BIN_TO_DOT_FILE_WITH_TS(GST_BIN(m_pipeline.get()), GST_DEBUG_GRAPH_SHOW_VERBOSE, "webkit-webrtc-encoder.error"); Is this useful or a debug left-over?
(In reply to Philippe Normand from comment #2) > Comment on attachment 364528 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=364528&action=review > > > Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp:146 > > + GST_DEBUG_BIN_TO_DOT_FILE_WITH_TS(GST_BIN(m_pipeline.get()), GST_DEBUG_GRAPH_SHOW_VERBOSE, "webkit-webrtc-encoder.error"); > > Is this useful or a debug left-over? I think it can be useful again in the future which is why I kept it.
Created attachment 365225 [details] Patch
Comment on attachment 365225 [details] Patch Attachment 365225 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/11575021 New failing tests: imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-constructor.html
Created attachment 365304 [details] Archive of layout-test-results from ews104 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 365225 [details] Patch Clearing flags on attachment: 365225 Committed r243196: <https://trac.webkit.org/changeset/243196>
All reviewed patches have been landed. Closing bug.
<rdar://problem/49055970>