Bug 195674 - [GStreamer][WebRTC]: Refactor to make the encoding happen synchronously
Summary: [GStreamer][WebRTC]: Refactor to make the encoding happen synchronously
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Thibault Saunier
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-13 07:21 PDT by Thibault Saunier
Modified: 2019-03-20 02:48 PDT (History)
6 users (show)

See Also:


Attachments
Patch (11.24 KB, patch)
2019-03-13 07:21 PDT, Thibault Saunier
no flags Details | Formatted Diff | Diff
Patch (11.26 KB, patch)
2019-03-19 13:56 PDT, Thibault Saunier
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews104 for mac-highsierra-wk2 (3.07 MB, application/zip)
2019-03-19 21:09 PDT, EWS Watchlist
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Thibault Saunier 2019-03-13 07:21:06 PDT
[GStreamer][WebRTC]: Refactor to make the encoding happen synchronously
Comment 1 Thibault Saunier 2019-03-13 07:21:50 PDT
Created attachment 364528 [details]
Patch
Comment 2 Philippe Normand 2019-03-19 09:48:22 PDT
Comment on attachment 364528 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364528&action=review

> Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp:146
> +            GST_DEBUG_BIN_TO_DOT_FILE_WITH_TS(GST_BIN(m_pipeline.get()), GST_DEBUG_GRAPH_SHOW_VERBOSE, "webkit-webrtc-encoder.error");

Is this useful or a debug left-over?
Comment 3 Thibault Saunier 2019-03-19 13:24:52 PDT
(In reply to Philippe Normand from comment #2)
> Comment on attachment 364528 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=364528&action=review
> 
> > Source/WebCore/platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp:146
> > +            GST_DEBUG_BIN_TO_DOT_FILE_WITH_TS(GST_BIN(m_pipeline.get()), GST_DEBUG_GRAPH_SHOW_VERBOSE, "webkit-webrtc-encoder.error");
> 
> Is this useful or a debug left-over?

I think it can be useful again in the future which is why I kept it.
Comment 4 Thibault Saunier 2019-03-19 13:56:33 PDT
Created attachment 365225 [details]
Patch
Comment 5 EWS Watchlist 2019-03-19 21:09:52 PDT
Comment on attachment 365225 [details]
Patch

Attachment 365225 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/11575021

New failing tests:
imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-constructor.html
Comment 6 EWS Watchlist 2019-03-19 21:09:54 PDT
Created attachment 365304 [details]
Archive of layout-test-results from ews104 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6
Comment 7 WebKit Commit Bot 2019-03-20 02:47:31 PDT
Comment on attachment 365225 [details]
Patch

Clearing flags on attachment: 365225

Committed r243196: <https://trac.webkit.org/changeset/243196>
Comment 8 WebKit Commit Bot 2019-03-20 02:47:32 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2019-03-20 02:48:19 PDT
<rdar://problem/49055970>