Bug 195658 - Enable libwebrtc logging control through WebCore
Summary: Enable libwebrtc logging control through WebCore
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-12 19:32 PDT by youenn fablet
Modified: 2019-03-13 10:14 PDT (History)
4 users (show)

See Also:

Attachments
Patch (10.75 KB, patch)
2019-03-12 20:24 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (10.75 KB, patch)
2019-03-13 08:38 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2019-03-12 19:32:29 PDT 
Enable libwebrtc logging control through WebCore
Comment 1 youenn fablet 2019-03-12 20:24:01 PDT 
Created attachment 364501 [details]
Patch
Comment 2 youenn fablet 2019-03-13 08:38:16 PDT 
Created attachment 364538 [details]
Patch
Comment 3 Radar WebKit Bug Importer 2019-03-13 09:21:07 PDT 
<rdar://problem/48849463>
Comment 4 Eric Carlson 2019-03-13 09:32:40 PDT 
Comment on attachment 364538 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364538&action=review

> Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:228
> +    if (!m_enableLogging)

Logging can never be enabled once it has been disabled?
Comment 5 youenn fablet 2019-03-13 09:43:01 PDT 
(In reply to Eric Carlson from comment #4)
> Comment on attachment 364538 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=364538&action=review
> 
> > Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:228
> > +    if (!m_enableLogging)
> 
> Logging can never be enabled once it has been disabled?

Yes, the logging is process wide for now.
If a private session page is in the same process as a non private session page, this might cause issues if we reenable logging and the private session page activity gets logged.
Comment 6 WebKit Commit Bot 2019-03-13 10:14:24 PDT 
Comment on attachment 364538 [details]
Patch

Clearing flags on attachment: 364538

Committed r242886: <https://trac.webkit.org/changeset/242886>
Comment 7 WebKit Commit Bot 2019-03-13 10:14:25 PDT 
All reviewed patches have been landed.  Closing bug.