Bug 195657 – [ContentChangeObserver] HTMLImageElement::willRespondToMouseClickEvents returns quirk value.

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[zalan]

:(

[Brent Fulgham]

This might be the worst thing ever.

[Radar WebKit Bug Importer]

<rdar://problem/48834987>

[zalan]

Created attachment 364500 [details]
Patch

[Brent Fulgham]

Why doesn't this have a review flag? Is the patch not correct?

[zalan]

(In reply to Brent Fulgham from comment #4)
> Why doesn't this have a review flag? Is the patch not correct?
Changelog entry -> "Wait and see if we could actually remove this quirk."

[Brent Fulgham]

(In reply to zalan from comment #5)
> (In reply to Brent Fulgham from comment #4)
> > Why doesn't this have a review flag? Is the patch not correct?
> Changelog entry -> "Wait and see if we could actually remove this quirk."

Wait for what, though? Some kind of test pass?

[zalan]

Created attachment 364830 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 364500 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364500&action=review

> Source/WebCore/page/ios/ContentChangeObserver.cpp:376
> +    if (is<HTMLImageElement>(element))
> +        return element.Element::willRespondToMouseClickEvents();

This needs an explanatory comment

[zalan]

Created attachment 364842 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 364842 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364842&action=review

> Source/WebCore/ChangeLog:9
> +        Wait and see if we could actually remove this quirk.

Pls update.

> Source/WebCore/page/ios/ContentChangeObserver.cpp:406
>      if (!m_hadRenderer)
> -        return const_cast<Element&>(m_element).willRespondToMouseClickEvents();
> +        return element.willRespondToMouseClickEvents();
>      ASSERT(m_element.renderer());
> -    if (const_cast<Element&>(m_element).willRespondToMouseClickEvents())
> +    if (element.willRespondToMouseClickEvents())
>          return true;

Maybe flip this logic around to have just one call to element.willRespondToMouseClickEvents

[zalan]

Created attachment 364845 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 364845 [details]
Patch

Rejecting attachment 364845 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 364845, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.

Full output: https://webkit-queues.webkit.org/results/11522464

[zalan]

(In reply to WebKit Commit Bot from comment #12)
> Comment on attachment 364845 [details]
> Patch
> 
> Rejecting attachment 364845 [details] from commit-queue.
> 
> Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch',
> '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01',
> 'validate-changelog', '--check-oops', '--non-interactive', 364845,
> '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
> 
> ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.
ohrly

[zalan]

Created attachment 364847 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 364847 [details]
Patch

Clearing flags on attachment: 364847

Committed r243017: <https://trac.webkit.org/changeset/243017>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.