:(
This might be the worst thing ever.
<rdar://problem/48834987>
Created attachment 364500 [details] Patch
Why doesn't this have a review flag? Is the patch not correct?
(In reply to Brent Fulgham from comment #4) > Why doesn't this have a review flag? Is the patch not correct? Changelog entry -> "Wait and see if we could actually remove this quirk."
(In reply to zalan from comment #5) > (In reply to Brent Fulgham from comment #4) > > Why doesn't this have a review flag? Is the patch not correct? > Changelog entry -> "Wait and see if we could actually remove this quirk." Wait for what, though? Some kind of test pass?
Created attachment 364830 [details] Patch
Comment on attachment 364500 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364500&action=review > Source/WebCore/page/ios/ContentChangeObserver.cpp:376 > + if (is<HTMLImageElement>(element)) > + return element.Element::willRespondToMouseClickEvents(); This needs an explanatory comment
Created attachment 364842 [details] Patch
Comment on attachment 364842 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=364842&action=review > Source/WebCore/ChangeLog:9 > + Wait and see if we could actually remove this quirk. Pls update. > Source/WebCore/page/ios/ContentChangeObserver.cpp:406 > if (!m_hadRenderer) > - return const_cast<Element&>(m_element).willRespondToMouseClickEvents(); > + return element.willRespondToMouseClickEvents(); > ASSERT(m_element.renderer()); > - if (const_cast<Element&>(m_element).willRespondToMouseClickEvents()) > + if (element.willRespondToMouseClickEvents()) > return true; Maybe flip this logic around to have just one call to element.willRespondToMouseClickEvents
Created attachment 364845 [details] Patch
Comment on attachment 364845 [details] Patch Rejecting attachment 364845 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 364845, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in LayoutTests/ChangeLog contains OOPS!. Full output: https://webkit-queues.webkit.org/results/11522464
(In reply to WebKit Commit Bot from comment #12) > Comment on attachment 364845 [details] > Patch > > Rejecting attachment 364845 [details] from commit-queue. > > Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', > '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', > 'validate-changelog', '--check-oops', '--non-interactive', 364845, > '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit > > ChangeLog entry in LayoutTests/ChangeLog contains OOPS!. ohrly
Created attachment 364847 [details] Patch
Comment on attachment 364847 [details] Patch Clearing flags on attachment: 364847 Committed r243017: <https://trac.webkit.org/changeset/243017>
All reviewed patches have been landed. Closing bug.