Bug 195657 - [ContentChangeObserver] HTMLImageElement::willRespondToMouseClickEvents returns quirk value.
Summary: [ContentChangeObserver] HTMLImageElement::willRespondToMouseClickEvents retur...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-12 19:14 PDT by zalan
Modified: 2019-03-15 15:18 PDT (History)
9 users (show)

See Also:


Attachments
Patch (5.60 KB, patch)
2019-03-12 20:19 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (5.25 KB, patch)
2019-03-15 13:31 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (6.55 KB, patch)
2019-03-15 14:15 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (6.71 KB, patch)
2019-03-15 14:31 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (6.70 KB, patch)
2019-03-15 14:40 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2019-03-12 19:14:02 PDT
:(
Comment 1 Brent Fulgham 2019-03-12 20:02:13 PDT
This might be the worst thing ever.
Comment 2 Radar WebKit Bug Importer 2019-03-12 20:15:02 PDT
<rdar://problem/48834987>
Comment 3 zalan 2019-03-12 20:19:12 PDT
Created attachment 364500 [details]
Patch
Comment 4 Brent Fulgham 2019-03-15 09:21:16 PDT
Why doesn't this have a review flag? Is the patch not correct?
Comment 5 zalan 2019-03-15 09:46:15 PDT
(In reply to Brent Fulgham from comment #4)
> Why doesn't this have a review flag? Is the patch not correct?
Changelog entry -> "Wait and see if we could actually remove this quirk."
Comment 6 Brent Fulgham 2019-03-15 09:47:31 PDT
(In reply to zalan from comment #5)
> (In reply to Brent Fulgham from comment #4)
> > Why doesn't this have a review flag? Is the patch not correct?
> Changelog entry -> "Wait and see if we could actually remove this quirk."

Wait for what, though? Some kind of test pass?
Comment 7 zalan 2019-03-15 13:31:56 PDT
Created attachment 364830 [details]
Patch
Comment 8 Simon Fraser (smfr) 2019-03-15 14:06:21 PDT
Comment on attachment 364500 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364500&action=review

> Source/WebCore/page/ios/ContentChangeObserver.cpp:376
> +    if (is<HTMLImageElement>(element))
> +        return element.Element::willRespondToMouseClickEvents();

This needs an explanatory comment
Comment 9 zalan 2019-03-15 14:15:56 PDT
Created attachment 364842 [details]
Patch
Comment 10 Simon Fraser (smfr) 2019-03-15 14:20:18 PDT
Comment on attachment 364842 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=364842&action=review

> Source/WebCore/ChangeLog:9
> +        Wait and see if we could actually remove this quirk.

Pls update.

> Source/WebCore/page/ios/ContentChangeObserver.cpp:406
>      if (!m_hadRenderer)
> -        return const_cast<Element&>(m_element).willRespondToMouseClickEvents();
> +        return element.willRespondToMouseClickEvents();
>      ASSERT(m_element.renderer());
> -    if (const_cast<Element&>(m_element).willRespondToMouseClickEvents())
> +    if (element.willRespondToMouseClickEvents())
>          return true;

Maybe flip this logic around to have just one call to element.willRespondToMouseClickEvents
Comment 11 zalan 2019-03-15 14:31:13 PDT
Created attachment 364845 [details]
Patch
Comment 12 WebKit Commit Bot 2019-03-15 14:37:50 PDT
Comment on attachment 364845 [details]
Patch

Rejecting attachment 364845 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 364845, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.

Full output: https://webkit-queues.webkit.org/results/11522464
Comment 13 zalan 2019-03-15 14:39:20 PDT
(In reply to WebKit Commit Bot from comment #12)
> Comment on attachment 364845 [details]
> Patch
> 
> Rejecting attachment 364845 [details] from commit-queue.
> 
> Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch',
> '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01',
> 'validate-changelog', '--check-oops', '--non-interactive', 364845,
> '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
> 
> ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.
ohrly
Comment 14 zalan 2019-03-15 14:40:11 PDT
Created attachment 364847 [details]
Patch
Comment 15 WebKit Commit Bot 2019-03-15 15:18:53 PDT
Comment on attachment 364847 [details]
Patch

Clearing flags on attachment: 364847

Committed r243017: <https://trac.webkit.org/changeset/243017>
Comment 16 WebKit Commit Bot 2019-03-15 15:18:54 PDT
All reviewed patches have been landed.  Closing bug.