Bug 195654 - Move the code for determining the need for touch bar quirks to Quirks class
Summary: Move the code for determining the need for touch bar quirks to Quirks class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2019-03-12 17:18 PDT by Ryosuke Niwa
Modified: 2019-03-12 21:11 PDT (History)
9 users (show)

See Also:


Attachments
Cleanup (19.08 KB, patch)
2019-03-12 17:59 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Cleanup (19.06 KB, patch)
2019-03-12 18:00 PDT, Ryosuke Niwa
bfulgham: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2019-03-12 17:18:32 PDT
WebPage::didApplyStyle() has the logic to determine whether hidden content editable and plain text quirks are needed.
Move these logics to Quirks class.
Comment 1 Wenson Hsieh 2019-03-12 17:20:42 PDT
(In reply to Ryosuke Niwa from comment #0)
> WebPage::didApplyStyle() has the logic to determine whether hidden content
> editable and plain text quirks are needed.
> Move these logics to Quirks class.

*WebPage::didChangeSelection
Comment 2 Ryosuke Niwa 2019-03-12 17:59:03 PDT
Created attachment 364488 [details]
Cleanup
Comment 3 Ryosuke Niwa 2019-03-12 18:00:39 PDT
Created attachment 364489 [details]
Cleanup
Comment 4 Brent Fulgham 2019-03-12 18:45:20 PDT
Comment on attachment 364489 [details]
Cleanup

View in context: https://bugs.webkit.org/attachment.cgi?id=364489&action=review

> Source/WebCore/page/Quirks.cpp:159
> +#if PLATFORM(MAC)

What about iOSMac? Would it maybe be needed there?

> Source/WebCore/page/Quirks.cpp:172
> +#if PLATFORM(MAC)

Ditto
Comment 5 Ryosuke Niwa 2019-03-12 19:17:54 PDT
(In reply to Brent Fulgham from comment #4)
> Comment on attachment 364489 [details]
> Cleanup
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=364489&action=review
> 
> > Source/WebCore/page/Quirks.cpp:159
> > +#if PLATFORM(MAC)
> 
> What about iOSMac? Would it maybe be needed there?

Wenson says we might. But the code which uses these checks are also guarded inside PLATFORM(MAC) so we'd probably have to fix both of them. I'm gonna leave the check as is for now.
Comment 6 Ryosuke Niwa 2019-03-12 19:31:42 PDT
Committed r242840: <https://trac.webkit.org/changeset/242840>
Comment 7 Radar WebKit Bug Importer 2019-03-12 19:32:19 PDT
<rdar://problem/48834165>