Bug 195648 - REGRESSION(r242825): "Broke webkitpy tests with my change to lldb_dump_class_layout.py" (Requested by rmorisset on #webkit).
Summary: REGRESSION(r242825): "Broke webkitpy tests with my change to lldb_dump_class_...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: WebKit Commit Bot
URL:
Keywords: InRadar
Depends on:
Blocks: 195573
  Show dependency treegraph
 
Reported: 2019-03-12 15:45 PDT by WebKit Commit Bot
Modified: 2019-03-12 15:50 PDT (History)
3 users (show)

See Also:


Attachments
ROLLOUT of r242825 (5.41 KB, patch)
2019-03-12 15:45 PDT, WebKit Commit Bot
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Commit Bot 2019-03-12 15:45:33 PDT
https://trac.webkit.org/changeset/242825 broke the build:
"Broke webkitpy tests with my change to lldb_dump_class_layout.py" (Requested by rmorisset on #webkit).

This is an automatic bug report generated by webkitbot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests fail.
Comment 1 WebKit Commit Bot 2019-03-12 15:45:38 PDT
Created attachment 364462 [details]
ROLLOUT of r242825

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 Robin Morisset 2019-03-12 15:47:52 PDT
Comment on attachment 364462 [details]
ROLLOUT of r242825

I had forgotten that there were already tests for this code, and broke them when changing the interface of lldb_dump_class_layout.py.
The fix is fairly simple, but I want to first roll-out, then take the time to fix it properly.
Comment 3 WebKit Commit Bot 2019-03-12 15:49:39 PDT
Comment on attachment 364462 [details]
ROLLOUT of r242825

Clearing flags on attachment: 364462

Committed r242832: <https://trac.webkit.org/changeset/242832>
Comment 4 WebKit Commit Bot 2019-03-12 15:49:41 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2019-03-12 15:50:17 PDT
<rdar://problem/48827374>