Bug 195648 – REGRESSION(r242825): "Broke webkitpy tests with my change to lldb_dump_class_layout.py" (Requested by rmorisset on #webkit).

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[WebKit Commit Bot]

https://trac.webkit.org/changeset/242825 broke the build:
"Broke webkitpy tests with my change to lldb_dump_class_layout.py" (Requested by rmorisset on #webkit).

This is an automatic bug report generated by webkitbot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests fail.

[WebKit Commit Bot]

Created attachment 364462 [details]
ROLLOUT of r242825

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.

[Robin Morisset]

Comment on attachment 364462 [details]
ROLLOUT of r242825

I had forgotten that there were already tests for this code, and broke them when changing the interface of lldb_dump_class_layout.py.
The fix is fairly simple, but I want to first roll-out, then take the time to fix it properly.

[WebKit Commit Bot]

Comment on attachment 364462 [details]
ROLLOUT of r242825

Clearing flags on attachment: 364462

Committed r242832: <https://trac.webkit.org/changeset/242832>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/48827374>