Bug 195632 - make_names.pl should use an array to hold all the QualifiedNames it produces.
Summary: make_names.pl should use an array to hold all the QualifiedNames it produces.
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-03-12 11:01 PDT by Keith Miller
Modified: 2019-03-12 12:52 PDT (History)
2 users (show)

See Also:

Attachments
WIP (67.01 KB, patch)
2019-03-12 11:01 PDT, Keith Miller 		ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-highsierra (537.73 KB, application/zip)
2019-03-12 11:57 PDT, EWS Watchlist 		no flags Details
Archive of layout-test-results from ews105 for mac-highsierra-wk2 (754.78 KB, application/zip)
2019-03-12 11:58 PDT, EWS Watchlist 		no flags Details
Archive of layout-test-results from ews112 for mac-highsierra (1.91 MB, application/zip)
2019-03-12 12:52 PDT, EWS Watchlist 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2019-03-12 11:01:17 PDT 
make_names.pl should use an array to hold all the QualifiedNames it produces.
Comment 1 Keith Miller 2019-03-12 11:01:44 PDT 
Created attachment 364408 [details]
WIP
Comment 2 EWS Watchlist 2019-03-12 11:04:26 PDT 
Attachment 364408 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/QualifiedName.cpp:29:  l is incorrectly named. Don't use the single letter 'l' as an identifier name.  [readability/naming] [4]
Total errors found: 1 in 26 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 EWS Watchlist 2019-03-12 11:57:29 PDT 
Comment on attachment 364408 [details]
WIP

Attachment 364408 [details] did not pass mac-ews (mac):
Output: https://webkit-queues.webkit.org/results/11478280

Number of test failures exceeded the failure limit.
Comment 4 EWS Watchlist 2019-03-12 11:57:30 PDT 
Created attachment 364422 [details]
Archive of layout-test-results from ews102 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-highsierra  Platform: Mac OS X 10.13.6
Comment 5 EWS Watchlist 2019-03-12 11:58:00 PDT 
Comment on attachment 364408 [details]
WIP

Attachment 364408 [details] did not pass mac-wk2-ews (mac-wk2):
Output: https://webkit-queues.webkit.org/results/11478244

Number of test failures exceeded the failure limit.
Comment 6 EWS Watchlist 2019-03-12 11:58:02 PDT 
Created attachment 364423 [details]
Archive of layout-test-results from ews105 for mac-highsierra-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-highsierra-wk2  Platform: Mac OS X 10.13.6
Comment 7 EWS Watchlist 2019-03-12 12:52:45 PDT 
Comment on attachment 364408 [details]
WIP

Attachment 364408 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/11478874

Number of test failures exceeded the failure limit.
Comment 8 EWS Watchlist 2019-03-12 12:52:47 PDT 
Created attachment 364430 [details]
Archive of layout-test-results from ews112 for mac-highsierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-highsierra  Platform: Mac OS X 10.13.6