NEW195632
make_names.pl should use an array to hold all the QualifiedNames it produces. 
https://bugs.webkit.org/show_bug.cgi?id=195632
Summary make_names.pl should use an array to hold all the QualifiedNames it produces.
Keith Miller
Reported 2019-03-12 11:01:17 PDT
make_names.pl should use an array to hold all the QualifiedNames it produces.
Attachments
WIP (67.01 KB, patch)
2019-03-12 11:01 PDT, Keith Miller 		ews-watchlist: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews102 for mac-highsierra (537.73 KB, application/zip)
2019-03-12 11:57 PDT, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews105 for mac-highsierra-wk2 (754.78 KB, application/zip)
2019-03-12 11:58 PDT, EWS Watchlist 		no flags
Details
Archive of layout-test-results from ews112 for mac-highsierra (1.91 MB, application/zip)
2019-03-12 12:52 PDT, EWS Watchlist 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2019-03-12 11:01:44 PDT
Created attachment 364408 [details] WIP
EWS Watchlist
Comment 2 2019-03-12 11:04:26 PDT
Attachment 364408 [details] did not pass style-queue: ERROR: Source/WebCore/dom/QualifiedName.cpp:29: l is incorrectly named. Don't use the single letter 'l' as an identifier name. [readability/naming] [4] Total errors found: 1 in 26 files If any of these errors are false positives, please file a bug against check-webkit-style.
EWS Watchlist
Comment 3 2019-03-12 11:57:29 PDT
Comment on attachment 364408 [details] WIP Attachment 364408 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/11478280 Number of test failures exceeded the failure limit.
EWS Watchlist
Comment 4 2019-03-12 11:57:30 PDT
Created attachment 364422 [details] Archive of layout-test-results from ews102 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-highsierra Platform: Mac OS X 10.13.6
EWS Watchlist
Comment 5 2019-03-12 11:58:00 PDT
Comment on attachment 364408 [details] WIP Attachment 364408 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/11478244 Number of test failures exceeded the failure limit.
EWS Watchlist
Comment 6 2019-03-12 11:58:02 PDT
Created attachment 364423 [details] Archive of layout-test-results from ews105 for mac-highsierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-highsierra-wk2 Platform: Mac OS X 10.13.6
EWS Watchlist
Comment 7 2019-03-12 12:52:45 PDT
Comment on attachment 364408 [details] WIP Attachment 364408 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/11478874 Number of test failures exceeded the failure limit.
EWS Watchlist
Comment 8 2019-03-12 12:52:47 PDT
Created attachment 364430 [details] Archive of layout-test-results from ews112 for mac-highsierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-highsierra Platform: Mac OS X 10.13.6
Note You need to log in before you can comment on or make changes to this bug.